[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Updated] D4803: Basic keyboard support + fixes to QuickShare plasmoid
From:       Yuen Hoe Lim <noreply () phabricator ! kde ! org>
Date:       2017-02-28 17:13:48
Message-ID: 20170228171346.93122.707.61413A5C () phabricator ! kde ! org
[Download RAW message or body]

yuenlim marked an inline comment as done.
yuenlim added inline comments.

INLINE COMMENTS

> mart wrote in AlternativesView.qml:101
> this should be a PlasmaComponents.Highlight instead

after discussion, should avoid using Plasma-specific components here (in purpose) for now. To \
use Rectangle without custom radius instead.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D4803

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: yuenlim, apol, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">yuenlim marked an inline comment as done.<br />yuenlim added inline \
comments. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px \
solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4803" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: \
6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: \
0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; \
margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: \
hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D4803#inline-19569" rel="noreferrer">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">mart</span> wrote in <span style="color: #4b4d51; \
font-weight: bold;">AlternativesView.qml:101</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">this should be a \
PlasmaComponents.Highlight instead</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">after discussion, should avoid using Plasma-specific \
components here (in purpose) for now. To use Rectangle without custom radius \
instead.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R495 \
Purpose Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4803" \
rel="noreferrer">https://phabricator.kde.org/D4803</a></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>yuenlim, apol, mart<br /><strong>Cc: </strong>mart, plasma-devel, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]