[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D4830: Adjust plasma-desktop to the new fallback prefixes
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2017-02-28 15:22:26
Message-ID: 20170228152216.92987.28620.D1D49D0B () phabricator ! kde ! org
[Download RAW message or body]
broulik added inline comments.
INLINE COMMENTS
> TaskProgressOverlay.qml:46
> imagePath: "widgets/tasks"
> - prefix: calculatePrefix()
> - onRepaintNeeded: prefix = calculatePrefix()
> -
> - function calculatePrefix() {
> - var prefix = TaskTools.taskPrefix("progress")
> - if (!frame.hasElementPrefix(prefix)) {
> - prefix = TaskTools.taskPrefix("hover")
> - }
> - return prefix
> - }
> + prefix: [TaskTools.taskPrefix("progress"), \
> TaskTools.taskPrefix("hover")] }
Now you place an array inside of an array.
(btw knotifications has a unitylauncher test app where you can test this, e.g. \
`~/Projects/kf5-build/knotifications/tests/unitylaunchertest org.kde.dolphin \
--progress 50`)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4830
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol
[Attachment #3 (text/html)]
<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4830" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4830#inline-19577" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">TaskProgressOverlay.qml:46</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "> <span style="color: #aa4000">imagePath:</span> <span \
style="color: #766510">"widgets/tasks"</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: \
#aa4000">prefix:</span> <span class="bright"></span><span style="color: \
#004012"><span class="bright">calculate</span>Prefix</span><span class="p">(<span \
class="bright">)</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: #ffd0d0;"> <span style="color: \
#aa4000">onRepaintNeeded:</span> <span style="color: #004012">prefix</span> <span \
style="color: #aa2211">=</span> <span style="color: \
#004012">calculatePrefix</span><span class="p">()</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: #ffd0d0;"> </div><div style="padding: 0 8px; margin: \
0 4px; background: #ffd0d0;"> <span style="color: #aa4000">function</span> \
<span style="color: #004012">calculatePrefix</span><span class="p">()</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#ffd0d0;"> <span style="color: #aa4000">var</span> <span style="color: \
#004012">prefix</span> <span style="color: #aa2211">=</span> <span style="color: \
#004012">TaskTools</span><span class="p">.</span><span style="color: \
#004012">taskPrefix</span><span class="p">(</span><span style="color: \
#766510">"progress"</span><span class="p">)</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span \
style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#aa2211">!</span><span style="color: #004012">frame</span><span \
class="p">.</span><span style="color: #004012">hasElementPrefix</span><span \
class="p">(</span><span style="color: #004012">prefix</span><span class="p">))</span> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#ffd0d0;"> <span style="color: #004012">prefix</span> <span \
style="color: #aa2211">=</span> <span style="color: #004012">TaskTools</span><span \
class="p">.</span><span style="color: #004012">taskPrefix</span><span \
class="p">(</span><span style="color: #766510">"hover"</span><span \
class="p">)</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#ffd0d0;"> <span class="p">}</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #ffd0d0;"> <span style="color: \
#aa4000">return</span> <span style="color: #004012">prefix</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span \
class="p">}</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;"> <span style="color: #aa4000">prefix:</span> <span \
class="bright"></span><span class="p"><span class="bright">[</span></span><span \
class="bright"></span><span style="color: #004012"><span \
class="bright">TaskTools</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">taskPrefix</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #766510"><span \
class="bright">"progress"</span></span><span class="bright"></span><span \
class="p"><span class="bright">),</span></span><span class="bright"> </span><span \
style="color: #004012"><span class="bright">TaskTools</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span style="color: #004012"><span \
class="bright">task</span>Prefix</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#766510"><span class="bright">"hover"</span></span><span \
class="bright"></span><span class="p"><span class="bright">)]</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Now you place an array inside of an array.</p>
<p style="padding: 0; margin: 8px;">(btw knotifications has a unitylauncher test app \
where you can test this, e.g. <tt style="background: #ebebeb; font-size: \
13px;">~/Projects/kf5-build/knotifications/tests/unitylaunchertest org.kde.dolphin \
--progress 50</tt>)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4830" \
rel="noreferrer">https://phabricator.kde.org/D4830</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>broulik, \
plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic