[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2
From: Marco Martin <noreply () phabricator ! kde ! org>
Date: 2017-02-28 12:34:06
Message-ID: 20170228123406.92889.57835.F786709D () phabricator ! kde ! org
[Download RAW message or body]
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in CMakeLists.txt:42
> It's easier to add something later than to remove it.
>
> I'd go with not installing for now, then revisit it. Maybe same for Menus.
ok. what about the combobox?
> davidedmundson wrote in Button.qml:28
> I don't get why we check background here and in other places. It would only be null \
> if a user subclassed this and then overwrote the property to undefined, at which \
> point they deserve errors.
good point
> davidedmundson wrote in Label.qml:27
> I still want this changed.
the reason for the padding is that it makes it correctly vertically aligned with \
other widgets both in a Row and a RowLayout. without this default height, every label \
should be manually vertically centered in layouts, and people will simply not do \
that, mostly because most people simply won't see the incorrect alignment, not even \
when explicitly pointed to them.
> davidedmundson wrote in qmldir:11
> Dialog and DialogButtonBox are listed here but aren't installed. I think that will \
> cause an error.
> And do we need CheckIndicator here?
removed.
no, all CheckIndicator,radioindicator and switchindicator are private, used by both \
the checkbox and checkdelegate, but not intended to be usable publicly
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4508
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, #frameworks, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol
[Attachment #3 (text/html)]
<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4508" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-19104" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:42</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">It's easier to add \
something later than to remove it.</p>
<p style="padding: 0; margin: 8px;">I'd go with not installing for now, then \
revisit it. Maybe same for Menus.</p></div></div> <div style="margin: 8px 0; padding: \
0 12px;"><p style="padding: 0; margin: 8px;">ok. what about the \
combobox?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-17970" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">Button.qml:28</span></div> <div style="margin: 8px 0; padding: 0 12px; color: \
#74777D;"><p style="padding: 0; margin: 8px;">I don't get why we check \
background here and in other places. It would only be null if a user subclassed this \
and then overwrote the property to undefined, at which point they deserve \
errors.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">good point</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D4508#inline-19105" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">davidedmundson</span> \
wrote in <span style="color: #4b4d51; font-weight: bold;">Label.qml:27</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">I still want this changed.</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">the reason for the padding is \
that it makes it correctly vertically aligned with other widgets both in a Row and a \
RowLayout.<br /> without this default height, every label should be manually \
vertically centered in layouts, and people will simply not do that, mostly because \
most people simply won't see the incorrect alignment, not even when explicitly \
pointed to them.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-19107" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">qmldir:11</span></div> <div style="margin: 8px 0; padding: 0 12px; color: \
#74777D;"><p style="padding: 0; margin: 8px;">Dialog and DialogButtonBox are listed \
here but aren't installed. I think that will cause an error.</p>
<p style="padding: 0; margin: 8px;">And do we need CheckIndicator \
here?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">removed.<br /> no, all CheckIndicator,radioindicator and \
switchindicator are private, used by both the checkbox and checkdelegate, but not \
intended to be usable publicly</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4508" \
rel="noreferrer">https://phabricator.kde.org/D4508</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, \
broulik, plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic