[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D4837: Applet: Make volume indicator icon bigger
From:       David Rosca <noreply () phabricator ! kde ! org>
Date:       2017-02-28 11:36:10
Message-ID: 20170228113609.105062.55092.7E1F99BC () phabricator ! kde ! org
[Download RAW message or body]

drosca added inline comments.

INLINE COMMENTS

> subdiff wrote in ListItemBase.qml:123
> Ok, ship it. To still easily distinguish the two icons we could place the sound \
> lines on the left side of the microphone and not on the right side like for the \
> speaker. @andreask, could you take a look at that?

I don't think placing the lines on the other side is the way to go. I created bug: \
https://bugs.kde.org/show_bug.cgi?id=377012

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  applet-indicator-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4837

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, subdiff
Cc: andreask, subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">drosca added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4837" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4837#inline-19548" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">subdiff</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">ListItemBase.qml:123</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">Ok, ship it. To still easily \
distinguish the two icons we could place the sound lines on the left side of the \
microphone and not on the right side like for the speaker. <a \
href="https://phabricator.kde.org/p/andreask/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@andreask</a>, could you take a \
look at that?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">I don&#039;t think placing the lines on the other \
side is the way to go. I created bug: <a \
href="https://bugs.kde.org/show_bug.cgi?id=377012" class="remarkup-link" \
target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=377012</a></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>applet-indicator-size (branched from \
master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4837" \
rel="noreferrer">https://phabricator.kde.org/D4837</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>drosca, Plasma, subdiff<br /><strong>Cc: \
</strong>andreask, subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]