From kde-panel-devel Sat Feb 25 23:59:22 2017 From: Martin Klapetek Date: Sat, 25 Feb 2017 23:59:22 +0000 To: kde-panel-devel Subject: Re: Review Request 123300: Make the dataengine alignment timer more precise Message-Id: <20170225235922.3284.83950 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=148806716809157 --===============6713554017852424613== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123300/ ----------------------------------------------------------- (Updated Feb. 25, 2017, 11:59 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit 2fea7077c84b97028a424d3e1d66f9838ccf9201 by Albert Astals Cid on behalf of Martin Klapetek to branch master. Repository: plasma-framework Description ------- It can and does happen that in case of two clocks, one with seconds and one without, the one without gets 1s behind. That's because the alignment is not corrected when the difference is 1s, however in case of the clock this 1s is cruicial. Diffs ----- src/plasma/private/datacontainer_p.cpp d9d33d7 Diff: https://git.reviewboard.kde.org/r/123300/diff/ Testing ------- Been running it for a bit of time (heh), so far no 1s delay. Thanks, Martin Klapetek --===============6713554017852424613== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123300/

This change has been marked as submitted.

Review request for Plasma.

By Martin Klapetek.

Updated Feb. 25, 2017, 11:59 p.m.

Changes

Submitted with commit 2fea7077c84b97028a424d3e1d66f9838ccf9201 by Albert Astals Cid on behalf of Martin Klapetek to branch master.

Repository: plasma-framework

Description

It can and does happen that in case of two clocks, one with seconds and one without, the one without gets 1s behind. That's because the alignment is not corrected when the difference is 1s, however in case of the clock this 1s is cruicial.

Testing

Been running it for a bit of time (heh), so far no 1s delay.

Diffs

src/plasma/private/datacontainer_p.cpp (d9d33d7)

View Diff

--===============6713554017852424613==--