'Re: Review Request 128109: Provide demo/preview for checkable menu items too [WIP]'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 128109: Provide demo/preview for checkable menu items too [WIP]
From:       René J.V. Bertin <rjvbertin () gmail ! com>
Date:       2017-02-08 15:53:17
Message-ID: 20170208155317.23155.83165 () mimi ! kde ! org
[Download RAW message or body]

--===============2435963758284201430==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128109/
-----------------------------------------------------------

(Updated Feb. 8, 2017, 3:53 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: oxygen


Description
-------

It's come up that there currently is no "official" preview for how checked menu items \
are rendered as a function of installed widget style.

This patch explores a straightforward way of doing that via the most exhaustive style \
preview utility I am aware of, Oxygen's demo app.

This demo already has menus in the MDI preview. The patch makes the layout items \
checkable and puts them in a QActionGroup so their mutually exclusive nature is taken \
into account. It also adds a "right to left" non-exclusive checkable item which is \
linked to the "Left to Right" checkbox in the demo frame.

I looked for an appropriate way to uncheck the Tile/Cascade/Tabbed menu items (= when \
the user moves or resizes one of the MDI windows) but it seems those events are not \
available through signals and would thus require subclassing MdiSubWindow .


Diffs
-----

  kstyle/demo/oxygendemodialog.h b296ec7 
  kstyle/demo/oxygendemodialog.cpp 4a742e3 
  kstyle/demo/oxygenmdidemowidget.h eafbeee 
  kstyle/demo/oxygenmdidemowidget.cpp 3e5422e 

Diff: https://git.reviewboard.kde.org/r/128109/diff/


Testing
-------

On Linux and OS X with KF5 5.22.0 and Qt 5.6.0


File Attachments
----------------

Screen Shot 2016-06-06 at 14.03.10.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/9d99ea87-8f35-4ad0-a15c-855ef80d7017__Screen_Shot_2016-06-06_at_14.03.10.png
 Screen Shot 2016-06-06 at 14.05.23.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/98364618-71c7-4715-864f-c6c0ce225544__Screen_Shot_2016-06-06_at_14.05.23.png
 Screen Shot 2016-06-06 at 14.07.04.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/948c598b-097c-438e-876f-88f6bbbfb30c__Screen_Shot_2016-06-06_at_14.07.04.png



Thanks,

René J.V. Bertin


--===============2435963758284201430==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128109/">https://git.reviewboard.kde.org/r/128109/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By René J.V. Bertin.</div>


<p style="color: grey;"><i>Updated Feb. 8, 2017, 3:53 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
oxygen
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It's come up that there currently is no "official" \
preview for how checked menu items are rendered as a function of installed widget \
style.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch explores a straightforward way of doing \
that via the most exhaustive style preview utility I am aware of, Oxygen's demo \
app.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This demo already has menus in the MDI preview. The \
patch makes the layout items checkable and puts them in a QActionGroup so their \
mutually exclusive nature is taken into account. It also adds a "right to left" \
non-exclusive checkable item which is linked to the "Left to Right" checkbox in the \
demo frame.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I looked for an appropriate way to uncheck the \
Tile/Cascade/Tabbed menu items (= when the user moves or resizes one of the MDI \
windows) but it seems those events are not available through signals and would thus \
require subclassing MdiSubWindow .</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On Linux and OS X with KF5 5.22.0 and Qt \
5.6.0</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstyle/demo/oxygendemodialog.h <span style="color: grey">(b296ec7)</span></li>

 <li>kstyle/demo/oxygendemodialog.cpp <span style="color: grey">(4a742e3)</span></li>

 <li>kstyle/demo/oxygenmdidemowidget.h <span style="color: \
grey">(eafbeee)</span></li>

 <li>kstyle/demo/oxygenmdidemowidget.cpp <span style="color: \
grey">(3e5422e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128109/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/9d99ea87-8f35-4ad0-a15c-855ef80d7017__Screen_Shot_2016-06-06_at_14.03.10.png">Screen \
Shot 2016-06-06 at 14.03.10.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/98364618-71c7-4715-864f-c6c0ce225544__Screen_Shot_2016-06-06_at_14.05.23.png">Screen \
Shot 2016-06-06 at 14.05.23.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/948c598b-097c-438e-876f-88f6bbbfb30c__Screen_Shot_2016-06-06_at_14.07.04.png">Screen \
Shot 2016-06-06 at 14.07.04.png</a></li>

</ul>




  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============2435963758284201430==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic