[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125897: [Clipboard plasmoid] Fix line breaks
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2017-02-08 14:24:36
Message-ID: 20170208142436.23155.38186 () mimi ! kde ! org
[Download RAW message or body]
--===============3437104850420095655==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125897/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 2:24 nachm.)
Status
------
This change has been marked as submitted.
Review request for Plasma, KDE Usability and Martin Gräßlin.
Repository: plasma-workspace
Description
-------
This fixes the list only showing one line of text instead of the supposed maximum of \
3 lines.
I'm unsure about the "m" modifier, however. With it, it highlights leading and \
trailing whitespace on any line which can be nice but also somewhat distracting \
depending on what you copied. On the other hand, only doing it for the first line (as \
is now but wasnt apparent because we only showed one line) is also strange. \
Especially when you use spaces rather than line breaks you can get quite a few \
"space" indicators.. (I can split the patch though, broken multiline display is \
definitely a bug)
Diffs
-----
applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656
Diff: https://git.reviewboard.kde.org/r/125897/diff/
Testing
-------
Works
File Attachments
----------------
With multiline modifier
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/24d3504f-856d-4548-b01a-4cf86b2cd348__klipperlinebreaks2.png
Without (currently)
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/d052169b-0026-4efa-b781-68b39cc20bf0__klipperlinebreaks1.png
Thanks,
Kai Uwe Broulik
--===============3437104850420095655==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125897/">https://git.reviewboard.kde.org/r/125897/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Martin Gräßlin.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2017, 2:24 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes the list only showing one line of text \
instead of the supposed maximum of 3 lines.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm unsure about the \
"m" modifier, however. With it, it highlights leading and trailing whitespace on any \
line which can be nice but also somewhat distracting depending on what you copied. On \
the other hand, only doing it for the first line (as is now but wasnt apparent \
because we only showed one line) is also strange. Especially when you use spaces \
rather than line breaks you can get quite a few "space" indicators.. (I can split the \
patch though, broken multiline display is definitely a bug)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/clipboard/contents/ui/ClipboardItemDelegate.qml <span style="color: \
grey">(b263656)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125897/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/24d3504f-856d-4548-b01a-4cf86b2cd348__klipperlinebreaks2.png">With \
multiline modifier</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/d052169b-0026-4efa-b781-68b39cc20bf0__klipperlinebreaks1.png">Without \
(currently)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3437104850420095655==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic