'Re: Review Request 123271: improve kickoff representation on vertical panels'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123271: improve kickoff representation on vertical panels
From:       Mathias Kraus <k.hias () gmx ! de>
Date:       2017-02-08 13:29:41
Message-ID: 20170208132941.23155.34338 () mimi ! kde ! org
[Download RAW message or body]

--===============1721915984435734590==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123271/
-----------------------------------------------------------

(Updated Feb. 8, 2017, 1:29 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: plasma-desktop


Description
-------

In vertical panels, the kickoff button is huge. This patch limits the size of the \
kickoff button.


Diffs
-----

  applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123271/diff/


Testing
-------

see screenshots


File Attachments
----------------

kickoff-horizontal-before
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png
 kickoff-horizontal-after
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png
 kickoff-vertical-before
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png
 kickoff-vertical-after
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png



Thanks,

Mathias Kraus


--===============1721915984435734590==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123271/">https://git.reviewboard.kde.org/r/123271/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Mathias Kraus.</div>


<p style="color: grey;"><i>Updated Feb. 8, 2017, 1:29 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In vertical panels, the kickoff button is huge. This \
patch limits the size of the kickoff button.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">see screenshots</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/kickoff/package/contents/ui/CompactRepresentation.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123271/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd \
-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png">kickoff-horizontal-before</a></li>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939 \
-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png">kickoff-horizontal-after</a></li>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86 \
-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png">kickoff-vertical-before</a></li>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a \
-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png">kickoff-vertical-after</a></li>


</ul>




  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============1721915984435734590==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic