[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2017-02-08 12:05:30
Message-ID: 20170208120530.23155.91651 () mimi ! kde ! org
[Download RAW message or body]
--===============4259409240533562940==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120855/#review102452
-----------------------------------------------------------
If this patch is still relevant please reopen on http://phabricator.kde.org
- David Edmundson
On Nov. 2, 2014, 3:34 p.m., Ashish Bansal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120855/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 3:34 p.m.)
>
>
> Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, \
> Sinny Kumari, and Sujith Haridasan.
>
> Bugs: 336398
> http://bugs.kde.org/show_bug.cgi?id=336398
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Changed auth method from Client Login to OAuth using libkgapi2
>
>
> Diffs
> -----
>
> browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d
> browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7
> browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240
> browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 \
> browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310
> browsingbackends/onlineservices/picasa/picasamodel.h 5bce055
> browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156
>
> Diff: https://git.reviewboard.kde.org/r/120855/diff/
>
>
> Testing
> -------
>
> Everything is working fine except that after successful login, user has to press \
> back to view all the albums.
>
> Thanks,
>
> Ashish Bansal
>
>
--===============4259409240533562940==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120855/">https://git.reviewboard.kde.org/r/120855/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
this patch is still relevant please reopen on http://phabricator.kde.org</p></pre> \
<br />
<p>- David Edmundson</p>
<br />
<p>On November 2nd, 2014, 3:34 p.m. UTC, Ashish Bansal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu \
Tushar, Sinny Kumari, and Sujith Haridasan.</div> <div>By Ashish Bansal.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2014, 3:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=336398">336398</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Changed auth method from Client Login to OAuth using \
libkgapi2</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything is working fine except that after \
successful login, user has to press back to view all the albums.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/onlineservices/picasa/CMakeLists.txt <span style="color: \
grey">(bd5052d)</span></li>
<li>browsingbackends/onlineservices/picasa/picasabackend.h <span style="color: \
grey">(7144dc7)</span></li>
<li>browsingbackends/onlineservices/picasa/picasabackend.cpp <span style="color: \
grey">(6317240)</span></li>
<li>browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml \
<span style="color: grey">(e8f97f7)</span></li>
<li>browsingbackends/onlineservices/picasa/picasacomponents/qmldir <span \
style="color: grey">(c790310)</span></li>
<li>browsingbackends/onlineservices/picasa/picasamodel.h <span style="color: \
grey">(5bce055)</span></li>
<li>browsingbackends/onlineservices/picasa/picasamodel.cpp <span style="color: \
grey">(2b64156)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120855/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4259409240533562940==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic