'Re: Review Request 128073: Make Wayland optional'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 128073: Make Wayland optional
From:       Pino Toscano <pino () kde ! org>
Date:       2017-02-08 11:48:20
Message-ID: 20170208114820.1135.56981 () mimi ! kde ! org
[Download RAW message or body]

--===============6363893109180266935==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128073/
-----------------------------------------------------------

(Updated Feb. 8, 2017, 11:48 a.m.)


Status
------

This change has been discarded.


Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and Sebastian \
Kügler.


Repository: libkscreen


Description
-------

Look for KF5Wayland as optional package, not building all the Wayland-related code \
(backend, additions to tests, DPMS support in kscreen-doctor) if it is not available.

This allows libkscreen to build again on platforms without Wayland, such as non-Linux \
or old Linux distros.


Diffs
-----

  CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b 
  autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 
  backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c 
  src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c 
  src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 
  tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 

Diff: https://git.reviewboard.kde.org/r/128073/diff/


Testing
-------

Builds fine.


Thanks,

Pino Toscano


--===============6363893109180266935==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128073/">https://git.reviewboard.kde.org/r/128073/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and \
Sebastian Kügler.</div> <div>By Pino Toscano.</div>


<p style="color: grey;"><i>Updated Feb. 8, 2017, 11:48 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Look for KF5Wayland as optional package, not building \
all the Wayland-related code (backend, additions to tests, DPMS support in \
kscreen-doctor) if it is not available.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This allows libkscreen \
to build again on platforms without Wayland, such as non-Linux or old Linux \
distros.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds fine.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(9c834d9500fa0b89764516464bd58e835671977b)</span></li>

 <li>autotests/CMakeLists.txt <span style="color: \
grey">(2c8ee3d2021b1222072d6a1faafaff1b336d27e3)</span></li>

 <li>backends/CMakeLists.txt <span style="color: \
grey">(3563e138454edcc0c874237745123b09077d067c)</span></li>

 <li>src/doctor/CMakeLists.txt <span style="color: \
grey">(7294d88af127a6604bc7e48e16342c93f152de8c)</span></li>

 <li>src/doctor/doctor.cpp <span style="color: \
grey">(a156f006212e63c155a6f643929d0a5880275731)</span></li>

 <li>tests/CMakeLists.txt <span style="color: \
grey">(1489d21383e13cd1431a81d48b4a272c28302041)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128073/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============6363893109180266935==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic