[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129932: Make tooltip interactive.
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2017-02-07 12:07:24
Message-ID: 20170207120724.23155.73949 () mimi ! kde ! org
[Download RAW message or body]
--===============6595852116562921094==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129932/#review102441
-----------------------------------------------------------
I agree with Marco.
Furthermore, introducing special tooltip behavior in just one Plasmoid is a no-no. \
Consistency is more important.
- Sebastian Kügler
On Feb. 7, 2017, 4:20 a.m., Garry Williams wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129932/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 4:20 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> The tooltip disappears too fast. Make the tooltip interactive to allow
> user to examine it longer.
>
>
> Diffs
> -----
>
> applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc06
>
> Diff: https://git.reviewboard.kde.org/r/129932/diff/
>
>
> Testing
> -------
>
> Applied to Fedora 25 and tested \
> (/usr/share/plasma/plasmoids/org.kde.plasma.systemloadviewer/contents/ui/SystemLoadViewer.qml).
>
>
> Thanks,
>
> Garry Williams
>
>
--===============6595852116562921094==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129932/">https://git.reviewboard.kde.org/r/129932/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
agree with Marco.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Furthermore, introducing special \
tooltip behavior in just one Plasmoid is a no-no. Consistency is more \
important.</p></pre> <br />
<p>- Sebastian Kügler</p>
<br />
<p>On February 7th, 2017, 4:20 a.m. UTC, Garry Williams wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Garry Williams.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2017, 4:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The tooltip disappears too fast. Make the tooltip \
interactive to allow user to examine it longer.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Applied to Fedora 25 and tested \
(/usr/share/plasma/plasmoids/org.kde.plasma.systemloadviewer/contents/ui/SystemLoadViewer.qml).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span \
style="color: grey">(5a0bc06)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129932/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6595852116562921094==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic