[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 16 lines] D4370: Set a longer wallpaper transition time
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-01-31 15:03:27
Message-ID: differential-rev-PHID-DREV-r4xll3eixiefn2nx7jyp-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Whilst using units is generally good, the wallpaper transition time is
  way too short. It's a different type of animation to the others,
  especially in a slideshow, where the transition is an important part of
  the behaviour.
  
  This patch loads it from a hidden configuration option with a duration
  of 1000ms, if and only if animations are enabled.
  
  Value determined through brief trial and error.
  
  BUG: 365979

TEST PLAN
  Opened wallpaper. Clicked next.
  Also changed static wallpaper manually, transition looked fine

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4370

AFFECTED FILES
  wallpapers/image/imagepackage/contents/config/main.xml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slideshowpackage/contents/config/main.xml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4370" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Whilst using units is generally good, the wallpaper \
transition time is<br /> way too short. It&#039;s a different type of animation to \
the others,<br /> especially in a slideshow, where the transition is an important \
part of<br /> the behaviour.</p>

<p>This patch loads it from a hidden configuration option with a duration<br />
of 1000ms, if and only if animations are enabled.</p>

<p>Value determined through brief trial and error.</p>

<p>BUG: 365979</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Opened \
wallpaper. Clicked next.<br /> Also changed static wallpaper manually, transition \
looked fine</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 \
Plasma Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4370" \
rel="noreferrer">https://phabricator.kde.org/D4370</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>wallpapers/image/imagepackage/contents/config/main.xml<br /> \
wallpapers/image/imagepackage/contents/ui/main.qml<br /> \
wallpapers/image/slideshowpackage/contents/config/main.xml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]