[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 14 lines] D4368: [Folder View] Open selection in preferred application inst
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-01-31 14:19:47
Message-ID: differential-rev-PHID-DREV-tkfyi6pnxvlaigs3h3ev-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
broulik added reviewers: Plasma, hein, emmanuelp.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This makes it consistent with Dolphin which will run scripts only if one is selected. If \
multiple are selected, they are opened in their preferred associated application (e.g. Kate) \
instead.  
  I also removed the restriction on opening folders when only one item is selected.
  
  CCBUG: 375793

TEST PLAN
  - Selected a script, hit return, got execution prompt (cf. https://phabricator.kde.org/D4367)
  - Selected two scripts, hit return, both of them were opened in Kate
  - Selected a folder, hit return, Dolphin opened it
  - Selected multiple folders, nothing happened
  - Selected multiple files and folders, only the files were opened in their associated \
application

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4368

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, emmanuelp
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, \
hein, emmanuelp.<br />broulik set the repository for this revision to R119 Plasma Desktop.<br \
/>Restricted Application added a project: Plasma.<br />Restricted Application added a \
subscriber: plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4368" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>This makes it consistent with Dolphin which will run scripts only if \
one is selected. If multiple are selected, they are opened in their preferred associated \
application (e.g. Kate) instead.</p>

<p>I also removed the restriction on opening folders when only one item is selected.</p>

<p>CCBUG: 375793</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul \
class="remarkup-list"> <li class="remarkup-list-item">Selected a script, hit return, got \
execution prompt (cf. <a href="https://phabricator.kde.org/D4367" style="background-color: \
#e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" rel="noreferrer">D4367</a>)</li>
<li class="remarkup-list-item">Selected two scripts, hit return, both of them were opened in \
Kate</li> <li class="remarkup-list-item">Selected a folder, hit return, Dolphin opened it</li>
<li class="remarkup-list-item">Selected multiple folders, nothing happened</li>
<li class="remarkup-list-item">Selected multiple files and folders, only the files were opened \
in their associated application</li> </ul></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4368" \
rel="noreferrer">https://phabricator.kde.org/D4368</a></div></div><br /><div><strong>AFFECTED \
FILES</strong><div><div>containments/desktop/plugins/folder/foldermodel.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, hein, emmanuelp<br /><strong>Cc: \
</strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]