[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 6 lines] D4367: [Folder View] show script execution prompt
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-01-31 14:00:16
Message-ID: differential-rev-PHID-DREV-xpu66cnbjqtpsdtx2552-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When clicking a file in FolderView, we should ask for whether to open or run a \
script depending on user settings.  This is what Dolphin does.
  
  BUG: 375793
  FIXED-IN: 5.8.6

TEST PLAN
  Created an .sh file, clicked it in FolderView, got a prompt. Selected multiple .sh \
files got a prompt for each one of them.  
  I just noticed that for multiple items Dolphin actually does
  
    KFileItemActions fileItemActions(this);
    fileItemActions.runPreferredApplications(items, QString());
  
  instead of going through KRun, ie. in Dolphin selecting two script files and \
hitting return will actually open them in Kate rather than execute them both. This \
needs to be addressed separately.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4367

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, hein.<br />broulik set the repository for this revision to R119 Plasma \
Desktop.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4367" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>When \
clicking a file in FolderView, we should ask for whether to open or run a script \
depending on user settings.<br /> This is what Dolphin does.</p>

<p>BUG: 375793<br />
FIXED-IN: 5.8.6</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Created \
an .sh file, clicked it in FolderView, got a prompt. Selected multiple .sh files got \
a prompt for each one of them.</p>

<p>I just noticed that for multiple items Dolphin actually does</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">KFileItemActions \
fileItemActions(this); fileItemActions.runPreferredApplications(items, \
QString());</pre></div>

<p>instead of going through KRun, ie. in Dolphin selecting two script files and \
hitting return will actually open them in Kate rather than execute them both. This \
needs to be addressed separately.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4367" \
rel="noreferrer">https://phabricator.kde.org/D4367</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>containments/desktop/plugins/folder/foldermodel.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: \
</strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]