[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D4362: RFC: [AppletQuickItem] Cache QQmlComponent used for settings Qt
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2017-01-31 11:19:01
Message-ID: 20170131111900.88546.64673.62BCE112 () phabricator ! kde ! org
[Download RAW message or body]
davidedmundson added a comment.
Personally I would just kill the whole thing.
- All Plasma code all uses Plasma Components not QQC so this has zero effect. It \
was for an idea that didn't really materialise
- It gives an obscure ASAN warning on freeing "o", that I don't know how to fix
- This isn't going to work with QQC2
INLINE COMMENTS
> appletquickitem.cpp:496
> + if (!c) {
> + c = new QQmlComponent(engine);
> + // FIXME never executed, even if I kquitapp plasmashell
if you were to do this:
just do c = new QQmlComponent(qApp);
and you have the cleanup done for you.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4362
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4362" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Personally I would just kill the whole \
thing.</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">All Plasma code all uses Plasma Components not QQC so \
this has zero effect. It was for an idea that didn't really materialise</li> <li \
class="remarkup-list-item">It gives an obscure ASAN warning on freeing "o", \
that I don't know how to fix</li> <li class="remarkup-list-item">This isn't \
going to work with QQC2</li> </ul></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D4362#inline-17458" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">appletquickitem.cpp:496</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span \
class="n"><span class="bright">c</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
class="n"><span class="bright">setData</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
class="n"><span class="bright">QByteArrayLiteral</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #766510"><span class="bright">"import \
QtQuick 2.1</span></span><span class="bright"></span><span style="color: \
#bb6622"><span class="bright">\n</span></span><span class="bright"></span><span \
style="color: #766510"><span class="bright">\</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"><span style="color: \
#766510"> <span class="bright">import QtQuick.Controls 1.0</span></span><span \
class="bright"></span><span style="color: #bb6622"><span \
class="bright">\n</span></span><span class="bright"></span><span style="color: \
#766510"><span class="bright">\</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #ffd0d0;"><span style="color: #766510"> <span \
class="bright">import QtQuick.Controls.Private 1.0</span></span><span \
class="bright"></span><span style="color: #bb6622"><span \
class="bright">\n</span></span><span class="bright"></span><span style="color: \
#766510"><span class="bright"> \</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span \
style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> \
</span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">!</span></span><span class="bright"></span><span class="n"><span \
class="bright">c</span></span><span class="bright"></span><span class="p"><span \
class="bright">)</span></span><span class="bright"> </span><span class="p"><span \
class="bright">{</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span class="bright"></span><span class="n"><span \
class="bright">c</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">=</span></span><span class="bright"> </span><span \
style="color: #aa4000"><span class="bright">new</span></span><span class="bright"> \
</span><span class="n"><span class="bright">QQmlComponent</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span class="bright">engine</span></span><span \
class="bright"></span><span class="p"><span class="bright">);</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="bright"></span><span style="color: #74777d"><span class="bright">// FIXME \
never executed, even if I kquitapp plasmashell</span></span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if \
you were to do this:<br /> just do c = new QQmlComponent(qApp);</p>
<p style="padding: 0; margin: 8px;">and you have the cleanup done for \
you.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4362" \
rel="noreferrer">https://phabricator.kde.org/D4362</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, Frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic