[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D3832: import kwin deco and button order in l&f
From:       graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date:       2017-01-03 15:48:06
Message-ID: 20170103154805.21452.15075.53A6FEB4 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added inline comments.

INLINE COMMENTS

> kcm.cpp:342
> +#endif
> +            setWindowDecoration(cg.readEntry("library", \
> QStringLiteral("org.kde.breeze")), cg.readEntry("theme", QString())); +        }

I think you got that part wrong. The difference is the value passed to library.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3832

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: Lucas, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas


[Attachment #3 (text/html)]

<table><tr><td style="">graesslin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3832" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3832#inline-15587" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kcm.cpp:342</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"><span style="color: #304a96">#endif</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span \
class="n">setWindowDecoration</span><span class="p">(</span><span \
class="n">cg</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span style="color: #766510">&quot;library&quot;</span><span \
class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span \
style="color: #766510">&quot;org.kde.breeze&quot;</span><span class="p">)),</span> \
<span class="n">cg</span><span class="p">.</span><span \
class="n">readEntry</span><span class="p">(</span><span style="color: \
#766510">&quot;theme&quot;</span><span class="p">,</span> <span \
class="n">QString</span><span class="p">()));</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: #d0ffd0;">        <span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">I think you got that part wrong. The difference is the value passed to \
library.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3832" \
rel="noreferrer">https://phabricator.kde.org/D3832</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>Lucas, graesslin, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]