[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129753: search and replace old hardcoded types from plasmapkg2
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2017-01-02 21:39:48
Message-ID: 20170102213948.31377.21454 () mimi ! kde ! org
[Download RAW message or body]
--===============7799600051101349506==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129753/#review101745
-----------------------------------------------------------
I'm a bit confused by one part:
kpackagetool5 --help
tells me:
-t, --type <type> The type of package, e.g. theme, wallpaper,
plasmoid, dataengine, runner, layout-template,
etc.
you're passing it something like -t Plasma/Applet
If this code is correct (and I think it is) the docs for kpackagetool5 are wrong.
src/plasmapkg/main.cpp (line 82)
<https://git.reviewboard.kde.org/r/129753/#comment68119>
why the replace?
plasmapkg2 --type plasmoid
will end up as
plasmapkg2 Plasma/Applet
that seems wrong?
- David Edmundson
On Jan. 2, 2017, 7:52 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129753/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2017, 7:52 p.m.)
>
>
> Review request for Plasma and Aleix Pol Gonzalez.
>
>
> Bugs: 374463
> http://bugs.kde.org/show_bug.cgi?id=374463
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> there is a single difference between command line parameters of plasmapkg2 and \
> kpackagetool5: plasmapkg2 had some hardcoded names like "theme", "plasmoid" etc. \
> kpackagetool5 requires the servicetype name to be passed instead. in order to stay \
> compatible convert those parameter with the proper servicetype name. it's parsing \
> parameters by hand in order to just pass anything else without further parsing
>
> Diffs
> -----
>
> src/plasma/packagestructure/plasmathemepackage.cpp 94f0c5c
> src/plasmapkg/main.cpp b61b2e5
>
> Diff: https://git.reviewboard.kde.org/r/129753/diff/
>
>
> Testing
> -------
>
> installing themes from knewstuff works again
>
>
> Thanks,
>
> Marco Martin
>
>
--===============7799600051101349506==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129753/">https://git.reviewboard.kde.org/r/129753/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm a \
bit confused by one part:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">kpackagetool5 --help tells me:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">-t, --type <type> The type of \
package, e.g. theme, wallpaper,
plasmoid, dataengine, runner, layout-template,
etc.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">you're passing it something like -t Plasma/Applet</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If this code is correct (and I think it is) the docs \
for kpackagetool5 are wrong.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129753/diff/2/?file=488468#file488468line82" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plasmapkg/main.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">82</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">params</span><span class="p">[</span><span \
class="n">typeIndex</span><span class="p">]</span> <span class="o">=</span> <span \
class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">"--type="</span><span class="p">)</span> <span class="o">+</span> \
<span class="n">typeFromLegacy</span><span class="p">(</span><span \
class="n">params</span><span class="p">.</span><span class="n">value</span><span \
class="p">(</span><span class="n">typeIndex</span><span class="p">).</span><span \
class="n">replace</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">"--type="</span><span class="p">),</span> <span \
class="n">QString</span><span class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why the replace?
plasmapkg2 --type plasmoid
will end up as
plasmapkg2 Plasma/Applet
that seems wrong?</pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On January 2nd, 2017, 7:52 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Aleix Pol Gonzalez.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Jan. 2, 2017, 7:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=374463">374463</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">there is a single difference between command line \
parameters of plasmapkg2 and kpackagetool5: plasmapkg2 had some hardcoded names like \
"theme", "plasmoid" etc. kpackagetool5 requires the servicetype name to be passed \
instead. in order to stay compatible convert those parameter with the proper \
servicetype name. it's parsing parameters by hand in order to just pass anything else \
without further parsing</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">installing themes from knewstuff works again</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/packagestructure/plasmathemepackage.cpp <span style="color: \
grey">(94f0c5c)</span></li>
<li>src/plasmapkg/main.cpp <span style="color: grey">(b61b2e5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129753/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7799600051101349506==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic