From kde-panel-devel  Sat Dec 31 22:02:42 2016
From: "xuetianweng (Xuetian Weng)" <noreply () phabricator ! kde ! org>
Date: Sat, 31 Dec 2016 22:02:42 +0000
To: kde-panel-devel
Subject: [Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput eve
Message-Id: <20161231220242.88430.17206.A23658B5 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=148322178210501
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--39a7112ec2ce4a468bb98685546602c7"

--39a7112ec2ce4a468bb98685546602c7
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

xuetianweng added a comment.


  In https://phabricator.kde.org/D3829#71988, @graesslin wrote:
  
  > In https://phabricator.kde.org/D3829#71877, @xuetianweng wrote:
  >
  > > In https://phabricator.kde.org/D3829#71714, @graesslin wrote:
  > >
  > > > Could you explain the relationship to global shortcuts? That sounds to me like a bug which needs to be fixed in kglobalaccel
  > >
  > >
  > > I don't really sure about this. So basically XlibNotifications uses XISelectEvent to monitor certain event. And strangely, the event is not received only if it is triggered by global hotkey.
  >
  >
  > Which "event"?
  
  
  search XIPropertyEvent in xlibnotifications.cpp
  
  For whatever reason, that part of code is not reached if it is triggered by global hotkey with current code, the display pointer is not shared with anyone.. I really don't understand why adding a new one helps, but it does help.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3829

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--39a7112ec2ce4a468bb98685546602c7
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td style=3D"">xuetianweng added a comment.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D3829" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><div><blockquote style=3D"border-left: 3px solid #8=
C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style=3D"font-style: normal;
          padding-bottom: 4px;">In <a href=3D"https://phabricator.kde.org/D=
3829#71988" style=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">D3829#719=
88</a>, <a href=3D"https://phabricator.kde.org/p/graesslin/" style=3D"
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel=3D"noreferrer">@graesslin</a> wrote:</=
div>
<div style=3D"margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style=3D"border-left: 3px=
 solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style=3D"font-style: normal;
          padding-bottom: 4px;">In <a href=3D"https://phabricator.kde.org/D=
3829#71877" style=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">D3829#718=
77</a>, <a href=3D"https://phabricator.kde.org/p/xuetianweng/" style=3D"
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel=3D"noreferrer">@xuetianweng</a> wrote:=
</div>
<div style=3D"margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style=3D"border-left: 3px=
 solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style=3D"font-style: normal;
          padding-bottom: 4px;">In <a href=3D"https://phabricator.kde.org/D=
3829#71714" style=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">D3829#717=
14</a>, <a href=3D"https://phabricator.kde.org/p/graesslin/" style=3D"
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel=3D"noreferrer">@graesslin</a> wrote:</=
div>
<div style=3D"margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Could you explain the relationship=
 to global shortcuts? That sounds to me like a bug which needs to be fixed =
in kglobalaccel</p></div>
</blockquote>

<p>I don&#039;t really sure about this. So basically XlibNotifications uses=
 XISelectEvent to monitor certain event. And strangely, the event is not re=
ceived only if it is triggered by global hotkey.</p></div>
</blockquote>

<p>Which &quot;event&quot;?</p></div>
</blockquote>

<p>search XIPropertyEvent in xlibnotifications.cpp</p>

<p>For whatever reason, that part of code is not reached if it is triggered=
 by global hotkey with current code, the display pointer is not shared with=
 anyone.. I really don&#039;t understand why adding a new one helps, but it=
 does help.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>=
R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</st=
rong><div><a href=3D"https://phabricator.kde.org/D3829" rel=3D"noreferrer">=
https://phabricator.kde.org/D3829</a></div></div><br /><div><strong>EMAIL P=
REFERENCES</strong><div><a href=3D"https://phabricator.kde.org/settings/pan=
el/emailpreferences/" rel=3D"noreferrer">https://phabricator.kde.org/settin=
gs/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>x=
uetianweng, davidedmundson<br /><strong>Cc: </strong>knambiar, graesslin, p=
lasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></=
div>
--39a7112ec2ce4a468bb98685546602c7--