From kde-panel-devel  Sat Dec 31 17:08:16 2016
From: "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date: Sat, 31 Dec 2016 17:08:16 +0000
To: kde-panel-devel
Subject: [Differential] [Request, 60 lines] D3892: [Icon Item] Support non-square icons
Message-Id: <differential-rev-PHID-DREV-rgx623ogsasyo4mk7ejx-req () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=148320410707724
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--709c2a6bedb9407689563cdc9c894ddc"

--709c2a6bedb9407689563cdc9c894ddc
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 355592

TEST PLAN
  Tests still pass, added a test for paintedWidth/paintedHeight
  F1663819: Screenshot_20161231_173902.png <https://phabricator.kde.org/F1663819>
  Now getting non-square thumbs in FolderView (will make a patch for FolderView to let IconItem span the full delegate width to make better use of available space for wide thumbs)
  Everything else looks as normal, icons still rounded to icon sizes and square usually, verified that paintedWidth/paintedHeight is always updated and correct

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3892

AFFECTED FILES
  autotests/iconitemtest.cpp
  autotests/iconitemtest.h
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--709c2a6bedb9407689563cdc9c894ddc
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, hein.<br />broulik set the repository for this revision to R242 Plasma Frameworks.<br />Restricted Application added projects: Plasma, Frameworks.<br />Restricted Application added a subscriber: plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3892" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>BUG: 355592</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Tests still pass, added a test for paintedWidth/paintedHeight<br />
<a href="https://phabricator.kde.org/F1663819" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F1663819: Screenshot_20161231_173902.png</a><br />
Now getting non-square thumbs in FolderView (will make a patch for FolderView to let IconItem span the full delegate width to make better use of available space for wide thumbs)<br />
Everything else looks as normal, icons still rounded to icon sizes and square usually, verified that paintedWidth/paintedHeight is always updated and correct</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Frameworks</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3892" rel="noreferrer">https://phabricator.kde.org/D3892</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/iconitemtest.cpp<br />
autotests/iconitemtest.h<br />
src/declarativeimports/core/iconitem.cpp<br />
src/declarativeimports/core/iconitem.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>
--709c2a6bedb9407689563cdc9c894ddc--