From kde-panel-devel  Sat Dec 31 17:04:32 2016
From: Roman Standzikowski <romanujan () gmail ! com>
Date: Sat, 31 Dec 2016 17:04:32 +0000
To: kde-panel-devel
Subject: Review Request 129736: KHoliday update - reworked holidays for Poland
Message-Id: <20161231170432.26347.10693 () mimi ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=148320388607700

--===============8801225205118807589==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129736/
-----------------------------------------------------------

Review request for Plasma.


Repository: kholidays


Description
-------

The patch contains updated holidays for Poland. This would fix bug https://bugs.kde.org/show_bug.cgi?id=365153.


For general information about polish holidays (especially the ones we do not work in Poland), see:

- see https://en.wikipedia.org/wiki/Public_holidays_in_Poland
- polish law act: http://isap.sejm.gov.pl/DetailsServlet?id=WDU20150000090

Changes:
- [most important, this HAS TO BE MAINLINED!!!] 6th of January is now a public holiday, since 2011 (see https://en.wikipedia.org/wiki/Epiphany_(holiday)#Poland)
- '?ledzik' is not really a religious holiday, this is just the last day of carnival (see https://en.wikipedia.org/wiki/Carnival#Poland), there are no special religious celebrations at this day in Poland
- moved Valentine's Day ('Walentynki') to civil holidays; I'm not really sure what is the different between 'civil' and 'cultural' holidays, but it seems no sense to have just the Valentine's Day in cultural and nothing else there
- 'Zaduszki' (full name: 'Dzie? Zaduszny') is definitely a religious holiday (see https://en.wikipedia.org/wiki/All_Souls%27_Day, https://pl.wikipedia.org/wiki/Zaduszki)
- 'Wigilia' is also a religious holiday (see https://en.wikipedia.org/wiki/Christmas_Eve, https://pl.wikipedia.org/wiki/Wigilia_Bo%C5%BCego_Narodzenia)
- 'Wniebowzi?cie NMP' ('Assumption of the Blessed Virgin Mary') is a bit complicated; this is both Army Day and Assumption of the Blessed Virgin Mary (see https://en.wikipedia.org/wiki/Public_holidays_in_Poland). Since in the polish law act the Assumption is mentioned, it is now a 'public religious', and the Army Day ('Dzie? Wojska Polskiego') was added as a civil one
- 'Lany Poniedzia?ek' ('Wet Monday') is a (still live) slavic-pagan tradition; since it is not mentioned in the polish law act, I have moved it to civil (this day is a holiday, because it is also a second day of Easter). I am not 100% sure about this change, any help would be welcome
- 'Dzie? Programisty' ('Programmers Day') added as a civil holiday; I couldn't resist :)
- added 'T?usty Czwartek' ('Fat Thursday' - https://en.wikipedia.org/wiki/Fat_Thursday#Poland); since there are no special religious celebrations this day, I have marked it as civil
- added 'Dzie? Górnika' ('Miners Day' - https://pl.wikipedia.org/wiki/Barb%C3%B3rka) - there are traditional celebration held in mining areas of Poland
- added 'Dzie? Edukacji Narodowej' ('Teacher's Day' - https://en.wikipedia.org/wiki/Teachers%27_Day), it is celebrated in every school
- renamed '?w' Miko?aj' to 'Miko?ajki', as this is more common name - see https://pl.wikipedia.org/wiki/Miko%C5%82ajki_(zwyczaj)
- polish 'Andrzejki' is a night 29/30 November (again, slavic-pagan tradition - https://pl.wikipedia.org/wiki/Andrzejki), not really the same as 'St. Andrew's Day'; moved to 29th November, as 30th November is already after the feast
- daylight saving time added (same time is in the whole European Union) - 'Czas letni', 'Czas zimowy'
- added 'Prima Aprilis' ('April Fools' Day')
- added 'Dzie? Solidarno?ci i Wolno?ci' ('Solidarity and Freedom Day' - see https://pl.wikipedia.org/wiki/Dzie%C5%84_Solidarno%C5%9Bci_i_Wolno%C5%9Bci)
- added 'Dzie? Zwyci?stwa' ('Victory Day' - see https://pl.wikipedia.org/wiki/Dzie%C5%84_Zwyci%C4%99stwa)
- added equinoxes and solstices
- added comment about polish school holidays


Diffs
-----

  holidays/plan2/holiday_pl_pl 54d56ac 

Diff: https://git.reviewboard.kde.org/r/129736/diff/


Testing
-------


Thanks,

Roman Standzikowski


--===============8801225205118807589==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129736/">https://git.reviewboard.kde.org/r/129736/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Roman Standzikowski.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kholidays
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch contains updated holidays for Poland. This would fix bug https://bugs.kde.org/show_bug.cgi?id=365153.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For general information about polish holidays (especially the ones we do not work in Poland), see:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">see https://en.wikipedia.org/wiki/Public_holidays_in_Poland</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">polish law act: http://isap.sejm.gov.pl/DetailsServlet?id=WDU20150000090</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changes:
- [most important, this HAS TO BE MAINLINED!!!] 6th of January is now a public holiday, since 2011 (see https://en.wikipedia.org/wiki/Epiphany_(holiday)#Poland)
- '?ledzik' is not really a religious holiday, this is just the last day of carnival (see https://en.wikipedia.org/wiki/Carnival#Poland), there are no special religious celebrations at this day in Poland
- moved Valentine's Day ('Walentynki') to civil holidays; I'm not really sure what is the different between 'civil' and 'cultural' holidays, but it seems no sense to have just the Valentine's Day in cultural and nothing else there
- 'Zaduszki' (full name: 'Dzie? Zaduszny') is definitely a religious holiday (see https://en.wikipedia.org/wiki/All_Souls%27_Day, https://pl.wikipedia.org/wiki/Zaduszki)
- 'Wigilia' is also a religious holiday (see https://en.wikipedia.org/wiki/Christmas_Eve, https://pl.wikipedia.org/wiki/Wigilia_Bo%C5%BCego_Narodzenia)
- 'Wniebowzi?cie NMP' ('Assumption of the Blessed Virgin Mary') is a bit complicated; this is both Army Day and Assumption of the Blessed Virgin Mary (see https://en.wikipedia.org/wiki/Public_holidays_in_Poland). Since in the polish law act the Assumption is mentioned, it is now a 'public religious', and the Army Day ('Dzie? Wojska Polskiego') was added as a civil one
- 'Lany Poniedzia?ek' ('Wet Monday') is a (still live) slavic-pagan tradition; since it is not mentioned in the polish law act, I have moved it to civil (this day is a holiday, because it is also a second day of Easter). I am not 100% sure about this change, any help would be welcome
- 'Dzie? Programisty' ('Programmers Day') added as a civil holiday; I couldn't resist :)
- added 'T?usty Czwartek' ('Fat Thursday' - https://en.wikipedia.org/wiki/Fat_Thursday#Poland); since there are no special religious celebrations this day, I have marked it as civil
- added 'Dzie? Górnika' ('Miners Day' - https://pl.wikipedia.org/wiki/Barb%C3%B3rka) - there are traditional celebration held in mining areas of Poland
- added 'Dzie? Edukacji Narodowej' ('Teacher's Day' - https://en.wikipedia.org/wiki/Teachers%27_Day), it is celebrated in every school
- renamed '?w' Miko?aj' to 'Miko?ajki', as this is more common name - see https://pl.wikipedia.org/wiki/Miko%C5%82ajki_(zwyczaj)
- polish 'Andrzejki' is a night 29/30 November (again, slavic-pagan tradition - https://pl.wikipedia.org/wiki/Andrzejki), not really the same as 'St. Andrew's Day'; moved to 29th November, as 30th November is already after the feast
- daylight saving time added (same time is in the whole European Union) - 'Czas letni', 'Czas zimowy'
- added 'Prima Aprilis' ('April Fools' Day')
- added 'Dzie? Solidarno?ci i Wolno?ci' ('Solidarity and Freedom Day' - see https://pl.wikipedia.org/wiki/Dzie%C5%84_Solidarno%C5%9Bci_i_Wolno%C5%9Bci)
- added 'Dzie? Zwyci?stwa' ('Victory Day' - see https://pl.wikipedia.org/wiki/Dzie%C5%84_Zwyci%C4%99stwa)
- added equinoxes and solstices
- added comment about polish school holidays</p></pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>holidays/plan2/holiday_pl_pl <span style="color: grey">(54d56ac)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129736/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============8801225205118807589==--