[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 4 lines] D3878: Use removeOne when uninstalling an InputEventFilter
From:       graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date:       2016-12-30 18:25:11
Message-ID: differential-rev-PHID-DREV-vlixtutbfyhzquammoke-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Adjusting to a difference from introducing the InputEventSpy. A filter
  may only be installed once. Thus removeOne is totally sufficient.
  
  Added a Q_ASSERT to ensure that it is not installed when installing.

REPOSITORY
  R108 KWin

BRANCH
  input-event-filter-remove-one

REVISION DETAIL
  https://phabricator.kde.org/D3878

AFFECTED FILES
  input.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">graesslin created this revision.<br />graesslin added \
reviewers: KWin, Plasma.<br />Restricted Application added a project: KWin.<br \
/>Restricted Application added subscribers: kwin, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3878" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Adjusting to a difference from introducing the InputEventSpy. \
A filter<br /> may only be installed once. Thus removeOne is totally sufficient.</p>

<p>Added a Q_ASSERT to ensure that it is not installed when \
installing.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>input-event-filter-remove-one</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3878" \
rel="noreferrer">https://phabricator.kde.org/D3878</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>input.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: \
</strong>plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, \
abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]