From kde-panel-devel  Fri Dec 30 18:09:57 2016
From: =?utf-8?q?graesslin_=28Martin_Gr=C3=A4=C3=9Flin=29?= <noreply () phabricator ! kde ! or
Date: Fri, 30 Dec 2016 18:09:57 +0000
To: kde-panel-devel
Subject: [Differential] [Commented On] D3832: import kwin deco and button order in l&f
Message-Id: <20161230180957.17410.80672.C12E8201 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=148312141026783
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--a7d05ca9f114425880e1a530fb46415c"

--a7d05ca9f114425880e1a530fb46415c
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

graesslin added inline comments.

INLINE COMMENTS

> kcm.cpp:337
> +            cg = KConfigGroup(&cg, "org.kde.kdecoration2");
> +            setWindowDecoration(cg.readEntry("library", QStringLiteral("org.kde.breeze")), cg.readEntry("theme", QString()));
> +        }

what remains is that this is not the default used in KWin.

In KWin it's:

  static const QString s_aurorae = QStringLiteral("org.kde.kwin.aurorae");
  static const QString s_pluginName = QStringLiteral("org.kde.kdecoration2");
  #if HAVE_BREEZE_DECO
  static const QString s_defaultPlugin = QStringLiteral(BREEZE_KDECORATION_PLUGIN_ID);
  #else
  static const QString s_defaultPlugin = s_aurorae;
  #endif

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3832

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: Lucas, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--a7d05ca9f114425880e1a530fb46415c
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td style=3D"">graesslin added inline comments.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D3832" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style=3D"=
margin: 6px 0 12px 0;"><div style=3D"border: 1px solid #C7CCD9; border-radi=
us: 3px;"><div style=3D"padding: 0; background: #F7F7F7; border-color: #e3e=
4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style=
=3D"color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden=
;"><a style=3D"float: right; text-decoration: none;" href=3D"https://phabri=
cator.kde.org/D3832#inline-15395" rel=3D"noreferrer">View Inline</a><span s=
tyle=3D"color: #4b4d51; font-weight: bold;">kcm.cpp:337</span></div>
<div style=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quo=
t;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px=
 0; margin: 0;"><div style=3D"padding: 0 8px; margin: 0 4px; background: #d=
0ffd0;">            <span class=3D"n">cg</span> <span style=3D"color: #aa22=
11">=3D</span> <span class=3D"n">KConfigGroup</span><span class=3D"p">(</sp=
an><span style=3D"color: #aa2211">&amp;</span><span class=3D"n">cg</span><s=
pan class=3D"p">,</span> <span style=3D"color: #766510">&quot;org.kde.kdeco=
ration2&quot;</span><span class=3D"p">);</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: #d0ffd0;">  =
          <span class=3D"n">setWindowDecoration</span><span class=3D"p">(</=
span><span class=3D"n">cg</span><span class=3D"p">.</span><span class=3D"n"=
>readEntry</span><span class=3D"p">(</span><span style=3D"color: #766510">&=
quot;library&quot;</span><span class=3D"p">,</span> <span class=3D"n">QStri=
ngLiteral</span><span class=3D"p">(</span><span style=3D"color: #766510">&q=
uot;org.kde.breeze&quot;</span><span class=3D"p">)),</span> <span class=3D"=
n">cg</span><span class=3D"p">.</span><span class=3D"n">readEntry</span><sp=
an class=3D"p">(</span><span style=3D"color: #766510">&quot;theme&quot;</sp=
an><span class=3D"p">,</span> <span class=3D"n">QString</span><span class=
=3D"p">()));</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: #d0ffd0;">  =
      <span class=3D"p">}</span>
</div></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">what remains is that this is not the default used in KWin.</p>

<p style=3D"padding: 0; margin: 8px;">In KWin it&#039;s:</p>

<div class=3D"remarkup-code-block" style=3D"margin: 12px 0;" data-code-lang=
=3D"text" data-sigil=3D"remarkup-code-block"><pre class=3D"remarkup-code" s=
tyle=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Mona=
co&quot;, monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120=
, 0.08);">static const QString s_aurorae =3D QStringLiteral(&quot;org.kde.k=
win.aurorae&quot;);
static const QString s_pluginName =3D QStringLiteral(&quot;org.kde.kdecorat=
ion2&quot;);
#if HAVE_BREEZE_DECO
static const QString s_defaultPlugin =3D QStringLiteral(BREEZE_KDECORATION_=
PLUGIN_ID);
#else
static const QString s_defaultPlugin =3D s_aurorae;
#endif</pre></div></div></div></div></div></div><br /><div><strong>REPOSITO=
RY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><stron=
g>REVISION DETAIL</strong><div><a href=3D"https://phabricator.kde.org/D3832=
" rel=3D"noreferrer">https://phabricator.kde.org/D3832</a></div></div><br /=
><div><strong>EMAIL PREFERENCES</strong><div><a href=3D"https://phabricator=
.kde.org/settings/panel/emailpreferences/" rel=3D"noreferrer">https://phabr=
icator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><=
strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>Lucas, graesslin=
, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /=
></div>
--a7d05ca9f114425880e1a530fb46415c--