[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D3870: [Converter Runner] Also convert to the user's local currency
From: "subdiff (Roman Gilg)" <noreply () phabricator ! kde ! org>
Date: 2016-12-30 15:49:54
Message-ID: 20161230154953.29353.48346.9651BC67 () phabricator ! kde ! org
[Download RAW message or body]
subdiff added a comment.
In https://phabricator.kde.org/D3870#72396, @davidedmundson wrote:
> (Slightly offtopic:
> when Martin G, eike or I make a diff, there's always an option to expand the \
context in phab to view lines above, when Kai or Subdiff make one, it says "Context \
not available" above the diff and I have to open files manually to work out what the \
code is doing. Does anyone know what's being done differently ?)
Maybe because I don't use Arcanist? I always did a `git diff master > diff_file`
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D3870
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, davidedmundson
Cc: subdiff, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">subdiff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3870" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3870#72396" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D3870#72396</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>(Slightly offtopic:<br />
when Martin G, eike or I make a diff, there's always an option to expand the \
context in phab to view lines above, when Kai or Subdiff make one, it says \
"Context not available" above the diff and I have to open files manually to \
work out what the code is doing. Does anyone know what's being done differently \
?)</p></div> </blockquote>
<p>Maybe because I don't use Arcanist? I always did a <tt style="background: \
#ebebeb; font-size: 13px;">git diff master > diff_file</tt></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3870" \
rel="noreferrer">https://phabricator.kde.org/D3870</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, davidedmundson<br /><strong>Cc: \
</strong>subdiff, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic