[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Accepted] D3870: [Converter Runner] Also convert to the user's local currency
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-12-30 13:57:04
Message-ID: 20161230135704.17861.30583.A6554317 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  not units.prepend(localCurrency) so it's first?
  
  (Slightly offtopic:
  when Martin G, eike or I make a diff, there's always an option to expand the \
context in phab to view lines above, when Kai or Subdiff make one, it says "Context \
not available" above the diff and I have to open files manually to work out what the \
code is doing. Does anyone know what's being done differently ?)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3870

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson \
added a reviewer: davidedmundson.<br />davidedmundson added a comment.<br />This \
revision is now accepted and ready to land. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3870" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>not units.prepend(localCurrency) so \
it&#039;s first?</p>

<p>(Slightly offtopic:<br />
when Martin G, eike or I make a diff, there&#039;s always an option to expand the \
context in phab to view lines above, when Kai or Subdiff make one, it says \
&quot;Context not available&quot; above the diff and I have to open files manually to \
work out what the code is doing. Does anyone know what&#039;s being done differently \
?)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma \
Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3870" \
rel="noreferrer">https://phabricator.kde.org/D3870</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]