[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D3617: [Touchpad KCM] New KWin Wayland version
From: sebas_(Sebastian_Kügler) <noreply () phabricator ! kde ! org>
Date: 2016-12-30 12:34:39
Message-ID: 20161230123438.26886.69305.4AD3767E () phabricator ! kde ! org
[Download RAW message or body]
sebas added a comment.
Clarified your questions.
My remaining comments are all non-critical so as long as you consider them, it's up \
to you if you change things or not. Just wanted to make sure it's not an oversight \
there.
INLINE COMMENTS
> ExclGroupBox.qml:53
> + id: tooltip
> + text: ""
> + }
default should already be empty, so you should be able to leave this line out.
> subdiff wrote in ToolTip.qml:45
> Whenever the running property is changed to false, it automatically should hide the \
> tooltip? But what happens, when it changes to false after a normal enter or \
> position change event and the timer triggered after its interval? Then the tooltip \
> would get hidden again directly.
Right, that could lead to glitches. Good thinking!
> subdiff wrote in main.qml:279
> Sorry, I don't understand. What does "value changed twice" mean?
What I mean is that this only prevents the rest of the codepath to run after the \
value has at least changed once. What if someone sets this value again before \
everything is properly initialized?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3617
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #kwin, #plasma_on_wayland, #plasma, #vdg
Cc: sebas, luebking, graesslin, knambiar, kwin, plasma-devel, lesliezhai, \
ali-mohamed, jensreuterberg, abetts
[Attachment #3 (text/html)]
<table><tr><td style="">sebas added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3617" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Clarified your questions.</p>
<p>My remaining comments are all non-critical so as long as you consider them, \
it's up to you if you change things or not. Just wanted to make sure it's \
not an oversight there.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D3617#inline-15359" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">ExclGroupBox.qml:53</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span style="color: \
#aa4000">id: tooltip</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span style="color: #aa4000">text:</span> \
<span style="color: #766510">""</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">default should already be empty, so you should be able to leave this \
line out.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3617#inline-15173" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">subdiff</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">ToolTip.qml:45</span></div> <div style="margin: 8px 0; padding: 0 12px; color: \
#74777D;"><p style="padding: 0; margin: 8px;">Whenever the running property is \
changed to false, it automatically should hide the tooltip? But what happens, when it \
changes to false after a normal enter or position change event and the timer \
triggered after its interval? Then the tooltip would get hidden again \
directly.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">Right, that could lead to glitches. Good \
thinking!</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3617#inline-15174" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">subdiff</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">main.qml:279</span></div> <div style="margin: 8px 0; padding: 0 12px; color: \
#74777D;"><p style="padding: 0; margin: 8px;">Sorry, I don't understand. What \
does "value changed twice" mean?</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">What I mean is that this only \
prevents the rest of the codepath to run after the value has at least changed once. \
What if someone sets this value again before everything is properly \
initialized?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3617" \
rel="noreferrer">https://phabricator.kde.org/D3617</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>subdiff, KWin, Plasma on Wayland, Plasma, VDG<br \
/><strong>Cc: </strong>sebas, luebking, graesslin, knambiar, kwin, plasma-devel, \
lesliezhai, ali-mohamed, jensreuterberg, abetts<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic