[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D3863: Introduce an InputEventSpy for processing input events
From: graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date: 2016-12-29 21:05:28
Message-ID: 20161229210528.17154.46023.2BF747F6 () phabricator ! kde ! org
[Download RAW message or body]
graesslin added inline comments.
INLINE COMMENTS
> sebas wrote in input.cpp:1394
> Wouldn't removeAll() be a bit safer here, or is there a good reason to have spies \
> enqueued twice? (In that case, duplicates should probably be checked before \
> insertion.
> In any case, it should be consistent with the filters' behaviour, so just something \
> to think about.
Yep agree. Having multiple filters/spies installed doesn't make sense. Due to that I \
chose remove one here. But the filters should be adjusted.
Not sure about checking proof to inserting. It's internal API, so I don't see a real \
benefit in adding the runtime cost. An asset could be a possibility, though.
> sebas wrote in input.h:192
> Code example would be nice here. Not critical, since it's not public API anyway, \
> but would help *me* personally to understand a bit better how to use it.
Yeah I'm aware that std::bind is something we hardly see in kde code yet (Ivan \
excluded). The example ae in this change. Giving an explicit code example here - \
difficult. Too much template magic and I do hope that there are booked and online \
resources which can explain it better than I could;-)
My suggestion would be to read the code example and check with the c++ documentation \
what it is doing
REPOSITORY
R108 KWin
BRANCH
input-event-spy
REVISION DETAIL
https://phabricator.kde.org/D3863
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma, sebas
Cc: sebas, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, \
abetts
[Attachment #3 (text/html)]
<table><tr><td style="">graesslin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3863" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3863#inline-15324" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">sebas</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">input.cpp:1394</span></div> <div style="margin: 8px 0; padding: 0 12px; color: \
#74777D;"><p style="padding: 0; margin: 8px;">Wouldn't removeAll() be a bit \
safer here, or is there a good reason to have spies enqueued twice? (In that case, \
duplicates should probably be checked before insertion.</p>
<p style="padding: 0; margin: 8px;">In any case, it should be consistent with the \
filters' behaviour, so just something to think about.</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yep \
agree. Having multiple filters/spies installed doesn't make sense. Due to that I \
chose remove one here. But the filters should be adjusted.</p>
<p style="padding: 0; margin: 8px;">Not sure about checking proof to inserting. \
It's internal API, so I don't see a real benefit in adding the runtime \
cost. An asset could be a possibility, though.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D3863#inline-15323" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">sebas</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">input.h:192</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Code example would be nice here. Not critical, since it's not public API \
anyway, but would help *me* personally to understand a bit better how to use \
it.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">Yeah I'm aware that std::bind is something we hardly see in kde \
code yet (Ivan excluded). The example ae in this change. Giving an explicit code \
example here - difficult. Too much template magic and I do hope that there are booked \
and online resources which can explain it better than I could;-)</p>
<p style="padding: 0; margin: 8px;">My suggestion would be to read the code example \
and check with the c++ documentation what it is \
doing</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>input-event-spy</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3863" \
rel="noreferrer">https://phabricator.kde.org/D3863</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, sebas<br /><strong>Cc: \
</strong>sebas, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic