[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D3832: import kwin deco and button order in l&f
From: graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date: 2016-12-29 15:52:34
Message-ID: 20161229155233.36231.41545.0932C8FF () phabricator ! kde ! org
[Download RAW message or body]
graesslin added a comment.
In https://phabricator.kde.org/D3832#71865, @mart wrote:
> In https://phabricator.kde.org/D3832#71855, @graesslin wrote:
>
> > I don't think the buttons should be set by a lnf package.
>
>
> the user request was to make possible the l&f themes to emulate a different os \
(that is actually part of the design reason of l&f themes) in which button order \
becomes part of the target look
the button order is global and not per theme. Given that I think it is wrong to \
change the global button order when changing theme. IIRC the deco can override it \
anyway, so not needed here.
INLINE COMMENTS
> kcm.cpp:642-646
> + // Reload KWin.
> + QDBusMessage message = QDBusMessage::createSignal(QStringLiteral("/KWin"),
> + \
> QStringLiteral("org.kde.KWin"), + \
> QStringLiteral("reloadConfig")); + QDBusConnection::sessionBus().send(message);
now we have two sections which will reload KWin's config. Can we merge that? A reload \
of KWin's config can be really expensive and we don't want to do that twice.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3832
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: Lucas, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas
[Attachment #3 (text/html)]
<table><tr><td style="">graesslin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3832" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3832#71865" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D3832#71865</a>, <a \
href="https://phabricator.kde.org/p/mart/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@mart</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3832#71855" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D3832#71855</a>, <a \
href="https://phabricator.kde.org/p/graesslin/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@graesslin</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I don't think the buttons should be set \
by a lnf package.</p></div> </blockquote>
<p>the user request was to make possible the l&f themes to emulate a different os \
(that is actually part of the design reason of l&f themes) in which button order \
becomes part of the target look</p></div> </blockquote>
<p>the button order is global and not per theme. Given that I think it is wrong to \
change the global button order when changing theme. IIRC the deco can override it \
anyway, so not needed here.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D3832#inline-15307" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kcm.cpp:642-646</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span style="color: #74777d">// Reload KWin.</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">QDBusMessage</span> <span class="n">message</span> <span style="color: \
#aa2211">=</span> <span class="n">QDBusMessage</span><span style="color: \
#aa2211">::</span><span class="n">createSignal</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"/KWin"</span><span class="p">),</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: #d0ffd0;"> \
<span class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"org.kde.KWin"</span><span class="p">),</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> \
<span class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"reloadConfig"</span><span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">QDBusConnection</span><span style="color: #aa2211">::</span><span \
class="n">sessionBus</span><span class="p">().</span><span class="n">send</span><span \
class="p">(</span><span class="n">message</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">now we have two sections which will reload KWin's config. Can we \
merge that? A reload of KWin's config can be really expensive and we don't \
want to do that twice.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3832" \
rel="noreferrer">https://phabricator.kde.org/D3832</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>Lucas, graesslin, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic