[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones
From: Martin Klapetek <martin.klapetek () gmail ! com>
Date: 2016-12-21 15:41:48
Message-ID: 20161221154148.6043.96839 () mimi ! kde ! org
[Download RAW message or body]
--===============3024244057980741706==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 21, 2016, 12:25 a.m., Aleix Pol Gonzalez wrote:
> > +0
> >
> > Note the correct patch would possibly be to port it to \
> > http://doc.qt.io/qt-5/qtimezone.html and drop that list...
Btw. this list exists because there is(/was) no way to get localized list of all \
countries from QTimeZone/QLocale.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129691/#review101524
-----------------------------------------------------------
On Dec. 20, 2016, 10:57 p.m., Jiri Bohac wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129691/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 10:57 p.m.)
>
>
> Review request for Plasma and Albert Astals Cid.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Update the list of country names to the current names in iso-codes
> (as output by isoquery -c).
>
> The motivation is updating the name of Czechia as a followup to
> https://git.reviewboard.kde.org/r/129644/
> As suggested by Albert Astals Cid, fixing the name in i10n is not enough:
> country names are hardcoded in many places and they need to be fixed separately.
>
>
> Diffs
> -----
>
> applets/digital-clock/plugin/timezonesi18n.cpp 10650f8
>
> Diff: https://git.reviewboard.kde.org/r/129691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiri Bohac
>
>
--===============3024244057980741706==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129691/">https://git.reviewboard.kde.org/r/129691/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 21st, 2016, 12:25 a.m. CET, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">+0</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Note the correct patch \
would possibly be to port it to http://doc.qt.io/qt-5/qtimezone.html and drop that \
list...</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Btw. \
this list exists because there is(/was) no way to get localized list of all countries \
from QTimeZone/QLocale.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On December 20th, 2016, 10:57 p.m. CET, Jiri Bohac wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Albert Astals Cid.</div>
<div>By Jiri Bohac.</div>
<p style="color: grey;"><i>Updated Dec. 20, 2016, 10:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Update the list of country names to the current names in iso-codes (as \
output by isoquery -c).
The motivation is updating the name of Czechia as a followup to
https://git.reviewboard.kde.org/r/129644/
As suggested by Albert Astals Cid, fixing the name in i10n is not enough:
country names are hardcoded in many places and they need to be fixed \
separately.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/plugin/timezonesi18n.cpp <span style="color: \
grey">(10650f8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129691/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3024244057980741706==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic