[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones
From: Pino Toscano <pino () kde ! org>
Date: 2016-12-20 23:46:33
Message-ID: 20161220234633.6043.77596 () mimi ! kde ! org
[Download RAW message or body]
--===============4180562950718823308==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 20, 2016, 10:46 p.m., Pino Toscano wrote:
> > TBH I don't think the Congo and CZ changes are somehow needed, since the current names are already \
> > the official names for the countries.
>
> Jiri Bohac wrote:
> The reason is consistency.
> The short names are used for all the remaining countries. It's inconsistent to use the long name for \
> two of them. Political names are not meant to be used in UI. You don't see "French Republic" or \
> "Federal Republic of Germany" in dropdown lists. CZ and CG now have an official short name just as the \
> others, so it should be used just as the others'.
Regarding CG, just using "Congo" is IMHO way too ambiguous, whereas the official names (which are much \
longer) are better in that -- hence I'd use them to help disambiguating. Regarding CZ, the "Czechia" \
change was done in iso-codes 3.71, released slightly more than one month ago (Nov 15th, 2016) -- that is \
a bit too new, no stable version of popular distros ship it already, so NACK for now (it could be changed \
in one year or so).
- Pino
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129691/#review101522
-----------------------------------------------------------
On Dec. 20, 2016, 9:57 p.m., Jiri Bohac wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129691/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 9:57 p.m.)
>
>
> Review request for Plasma and Albert Astals Cid.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Update the list of country names to the current names in iso-codes
> (as output by isoquery -c).
>
> The motivation is updating the name of Czechia as a followup to
> https://git.reviewboard.kde.org/r/129644/
> As suggested by Albert Astals Cid, fixing the name in i10n is not enough:
> country names are hardcoded in many places and they need to be fixed separately.
>
>
> Diffs
> -----
>
> applets/digital-clock/plugin/timezonesi18n.cpp 10650f8
>
> Diff: https://git.reviewboard.kde.org/r/129691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiri Bohac
>
>
--===============4180562950718823308==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129691/">https://git.reviewboard.kde.org/r/129691/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 20th, 2016, 10:46 p.m. UTC, <b>Pino Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">TBH I don't think the Congo and CZ changes are somehow needed, since the \
current names are already the official names for the countries.</p></pre> </blockquote>
<p>On December 20th, 2016, 11:16 p.m. UTC, <b>Jiri Bohac</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">The reason is consistency. The short names are used for all the \
remaining countries. It's inconsistent to use the long name for two of them. Political names are not \
meant to be used in UI. You don't see "French Republic" or "Federal Republic of \
Germany" in dropdown lists. CZ and CG now have an official short name just as the others, so it \
should be used just as the others'.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Regarding CG, just using "Congo" is IMHO way too ambiguous, whereas the \
official names (which are much longer) are better in that -- hence I'd use them to help disambiguating. \
Regarding CZ, the "Czechia" change was done in iso-codes 3.71, released slightly more than one month ago \
(Nov 15th, 2016) -- that is a bit too new, no stable version of popular distros ship it already, so NACK \
for now (it could be changed in one year or so).</p></pre> <br />
<p>- Pino</p>
<br />
<p>On December 20th, 2016, 9:57 p.m. UTC, Jiri Bohac wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Albert Astals Cid.</div>
<div>By Jiri Bohac.</div>
<p style="color: grey;"><i>Updated Dec. 20, 2016, 9:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update the list of country names to the \
current names in iso-codes (as output by isoquery -c).
The motivation is updating the name of Czechia as a followup to
https://git.reviewboard.kde.org/r/129644/
As suggested by Albert Astals Cid, fixing the name in i10n is not enough:
country names are hardcoded in many places and they need to be fixed separately.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/plugin/timezonesi18n.cpp <span style="color: grey">(10650f8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129691/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4180562950718823308==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic