[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones
From: Pino Toscano <pino () kde ! org>
Date: 2016-12-20 22:46:54
Message-ID: 20161220224654.6043.79872 () mimi ! kde ! org
[Download RAW message or body]
--===============0073203525336783334==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129691/#review101522
-----------------------------------------------------------
TBH I don't think the Congo and CZ changes are somehow needed, since the current \
names are already the official names for the countries.
applets/digital-clock/plugin/timezonesi18n.cpp (line 531)
<https://git.reviewboard.kde.org/r/129691/#comment67963>
This follows the official name already, not the common name, so the change is not \
needed.
applets/digital-clock/plugin/timezonesi18n.cpp (line 717)
<https://git.reviewboard.kde.org/r/129691/#comment67967>
Theoretically "Czech Republic" is correct as well, since it's the official name \
(as also recorded by iso-codes).
- Pino Toscano
On Dec. 20, 2016, 9:57 p.m., Jiri Bohac wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129691/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 9:57 p.m.)
>
>
> Review request for Plasma and Albert Astals Cid.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Update the list of country names to the current names in iso-codes
> (as output by isoquery -c).
>
> The motivation is updating the name of Czechia as a followup to
> https://git.reviewboard.kde.org/r/129644/
> As suggested by Albert Astals Cid, fixing the name in i10n is not enough:
> country names are hardcoded in many places and they need to be fixed separately.
>
>
> Diffs
> -----
>
> applets/digital-clock/plugin/timezonesi18n.cpp 10650f8
>
> Diff: https://git.reviewboard.kde.org/r/129691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiri Bohac
>
>
--===============0073203525336783334==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129691/">https://git.reviewboard.kde.org/r/129691/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">TBH I \
don't think the Congo and CZ changes are somehow needed, since the current names are \
already the official names for the countries.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129691/diff/1/?file=487931#file487931line531" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/digital-clock/plugin/timezonesi18n.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">531</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">ENTRY_ISO_3166</span><span class="p">(</span><span \
class="n">CongoBrazzaville</span><span class="p">,</span> <span class="s">"<span \
class="hl">Republic of the </span>Congo"</span><span \
class="p">),</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">531</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="n">ENTRY_ISO_3166</span><span class="p">(</span><span \
class="n">CongoBrazzaville</span><span class="p">,</span> <span \
class="s">"Congo"</span><span class="p">),</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This follows the \
official name already, not the common name, so the change is not needed.</pre> \
</div> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129691/diff/1/?file=487931#file487931line717" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/digital-clock/plugin/timezonesi18n.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">715</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">ENTRY_ISO_3166</span><span class="p">(</span><span \
class="n">CzechRepublic</span><span class="p">,</span> <span \
class="s">"Czech<span class="hl"> Republic</span>"</span><span \
class="p">),</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">717</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="n">ENTRY_ISO_3166</span><span class="p">(</span><span \
class="n">CzechRepublic</span><span class="p">,</span> <span \
class="s">"Czech<span class="hl">ia</span>"</span><span \
class="p">),</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Theoretically \
"Czech Republic" is correct as well, since it's the official name (as \
also recorded by iso-codes).</pre> </div>
</div>
<br />
<p>- Pino Toscano</p>
<br />
<p>On December 20th, 2016, 9:57 p.m. UTC, Jiri Bohac wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Albert Astals Cid.</div>
<div>By Jiri Bohac.</div>
<p style="color: grey;"><i>Updated Dec. 20, 2016, 9:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Update the list of country names to the current names in iso-codes (as \
output by isoquery -c).
The motivation is updating the name of Czechia as a followup to
https://git.reviewboard.kde.org/r/129644/
As suggested by Albert Astals Cid, fixing the name in i10n is not enough:
country names are hardcoded in many places and they need to be fixed \
separately.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/plugin/timezonesi18n.cpp <span style="color: \
grey">(10650f8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129691/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0073203525336783334==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic