'Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect in group item'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect in group item
From:       Anthony Fieroni <bvbfan () abv ! bg>
Date:       2016-12-16 4:38:33
Message-ID: 20161216043833.4515.62889 () mimi ! kde ! org
[Download RAW message or body]

--===============7544449962022200440==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128038/
-----------------------------------------------------------

(Updated Dec. 16, 2016, 4:38 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Eike Hein.


Changes
-------

Submitted with commit aeec4ae8869b487fe516a920b49a1fde4ea48c06 by Anthony Fieroni to \
branch Plasma/5.8.


Repository: plasma-desktop


Description
-------

1. Enable highlighted window, tooltips and grouping
2. Open group item tasl by clicking left mouse button
3. Move mouse cursor over item in group

Before:
1. Items are samll and tough readable
2. Items aren't visible cause a highligthWindow effect
3. Clicking on tooltip close button case highlightWindow effect to not stop

After:
1. Items are proof readable
2. Items are visible
3. HighlightWdindow effect is stopped


Diffs
-----

  applets/taskmanager/package/contents/ui/GroupDialog.qml 829fcf0 
  applets/taskmanager/package/contents/ui/Task.qml 0a59d53 
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml e3551df 
  applets/taskmanager/package/contents/ui/main.qml e53b194 
  applets/taskmanager/plugin/backend.h a3788b0 
  applets/taskmanager/plugin/backend.cpp 4ef5b88 

Diff: https://git.reviewboard.kde.org/r/128038/diff/


Testing
-------

Screenshot with expected behavior by clicking left button on group item.


File Attachments
----------------

Vertical panel
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/35dd438c-fae2-4daa-ba30-09f70ea3b920__Screenshot_20161203_210914.png
 Horizontal panel
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/fe7c9cab-bb2a-4d17-85de-1934c81a33dc__Screenshot_20161203_211120.png



Thanks,

Anthony Fieroni


--===============7544449962022200440==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128038/">https://git.reviewboard.kde.org/r/128038/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Eike \
Hein.</div> <div>By Anthony Fieroni.</div>


<p style="color: grey;"><i>Updated Dec. 16, 2016, 4:38 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit aeec4ae8869b487fe516a920b49a1fde4ea48c06 by \
Anthony Fieroni to branch Plasma/5.8.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Enable highlighted \
window, tooltips and grouping</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Open group item tasl by \
clicking left mouse button</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Move mouse cursor over item in \
group</li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Before: 1. Items are samll and tough readable
2. Items aren't visible cause a highligthWindow effect
3. Clicking on tooltip close button case highlightWindow effect to not stop</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">After: 1. Items are proof readable
2. Items are visible
3. HighlightWdindow effect is stopped</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Screenshot with expected behavior by clicking left \
button on group item.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/taskmanager/package/contents/ui/GroupDialog.qml <span style="color: \
grey">(829fcf0)</span></li>

 <li>applets/taskmanager/package/contents/ui/Task.qml <span style="color: \
grey">(0a59d53)</span></li>

 <li>applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml <span \
style="color: grey">(e3551df)</span></li>

 <li>applets/taskmanager/package/contents/ui/main.qml <span style="color: \
grey">(e53b194)</span></li>

 <li>applets/taskmanager/plugin/backend.h <span style="color: \
grey">(a3788b0)</span></li>

 <li>applets/taskmanager/plugin/backend.cpp <span style="color: \
grey">(4ef5b88)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128038/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/35dd438c-fae2-4daa-ba30-09f70ea3b920__Screenshot_20161203_210914.png">Vertical \
panel</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/fe7c9cab-bb2a-4d17-85de-1934c81a33dc__Screenshot_20161203_211120.png">Horizontal \
panel</a></li>

</ul>




  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============7544449962022200440==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic