[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 4 lines] D3552: Remove quoting from kscreen-console json-output (Bug 354534
From:       "jbraun (Jan-Matthias Braun)" <noreply () phabricator ! kde ! org>
Date:       2016-11-30 21:12:19
Message-ID: differential-rev-PHID-DREV-lu2pdjqoayut6dste3jx-req () phabricator ! kde ! org
[Download RAW message or body]

jbraun created this revision.
jbraun added a reviewer: sebas.
jbraun set the repository for this revision to R104 KScreen.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As the creator of Bug 354534 noted, the output of
  
    kscreen-console json
  
  contains quotations seem to be generated from the qDebug()-Output stream.
  
  The proposed fix is to convert the QString to a C++ std::string and use std::cout for output.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D3552

AFFECTED FILES
  b/console/console.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jbraun, sebas
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">jbraun created this revision.<br />jbraun added a reviewer: \
sebas.<br />jbraun set the repository for this revision to R104 KScreen.<br \
/>Restricted Application added a project: Plasma.<br />Restricted Application added a \
subscriber: plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3552" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>As the \
creator of Bug 354534 noted, the output of</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">kscreen-console \
json</pre></div>

<p>contains quotations seem to be generated from the qDebug()-Output stream.</p>

<p>The proposed fix is to convert the QString to a C++ std::string and use std::cout \
for output.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R104 \
KScreen</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3552" \
rel="noreferrer">https://phabricator.kde.org/D3552</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>b/console/console.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>jbraun, sebas<br /><strong>Cc: </strong>plasma-devel, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]