[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D3539: [Notifications] Show interactive thumbnails on notifications
From:       "mart (Marco Martin)" <noreply () phabricator ! kde ! org>
Date:       2016-11-30 16:20:37
Message-ID: 20161130162036.31233.84190.36EA825F () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  I like the idea, but i am a bit concerned about the added complexity, that may be worked around?

INLINE COMMENTS

> NotificationItem.qml:318
> +
> +        ListView {
> +            id: previewList

the main concern i have, is the general weight of QML.
this is going to make worse both memory usage and time to instantiate the notification item, regarless if \
                the notification has urls or not...
idea: could all of this part be in a loader that actually parses the component and instantiates the whole \
listview only if there is at least one url?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3539

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; \
font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3539" rel="noreferrer">View Revision</a></tr></table><br \
/><div><div><p>I like the idea, but i am a bit concerned about the added complexity, that may be worked \
around?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px \
0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: \
#F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3539#inline-13930" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationItem.qml:318</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 \
4px; background: #d0ffd0;">        <span style="color: #004012">ListView</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: \
#aa4000">id: previewList</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the main concern i have, \
is the general weight of QML.<br /> this is going to make worse both memory usage and time to instantiate \
                the notification item, regarless if the notification has urls or not...<br />
idea: could all of this part be in a loader that actually parses the component and instantiates the whole \
listview only if there is at least one url?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3539" \
rel="noreferrer">https://phabricator.kde.org/D3539</a></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, Plasma: Design<br /><strong>Cc: </strong>mart, colomar, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]