[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D3479: [libinput] Add more support for touchpads in preparation for th
From:       "subdiff (Roman Gilg)" <noreply () phabricator ! kde ! org>
Date:       2016-11-30 15:59:36
Message-ID: 20161130155936.30587.34131.B805601B () phabricator ! kde ! org
[Download RAW message or body]

subdiff added a comment.


  In https://phabricator.kde.org/D3479#66129, @graesslin wrote:
  
  > @davidedmundson do you have any further comments on the DBus usage? if not, I \
would give it an "Accepted".  
  
  At the moment @davidedmundson helps me with the dbus signals.  I tried to implement \
them, but the problem was, that the processEvents() loop is in a different thread \
than the Connection instance. Because of that the signals weren't forwarded to D-Bus \
(hard to see).  
  He told me that he has an idea how to solve the problem. If this doesn't work \
though, I would suggest that we ignore the problem of the changing device list on \
plugging events. For my touchpad KCM it's in some way irrelevant anyway, because:  
  1. Most touchpads aren't removable.
  2. On the rare occasion of a user plugging in or disconnecting a touchpad while \
being in the touchpad KCM, I would use the signal only to show a warning message to \
the user, that he should restart the KCM (I think it's over-engineered to implement \
logic to update the device list in real time in these very rare cases).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3479

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #kwin, #plasma
Cc: graesslin, davidedmundson, plasma-devel, kwin, #kwin, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">subdiff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3479" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3479#66129" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D3479#66129</a>, <a \
href="https://phabricator.kde.org/p/graesslin/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@graesslin</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p><a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> do you have any \
further comments on the DBus usage? if not, I would give it an \
&quot;Accepted&quot;.</p></div> </blockquote>

<p>At the moment <a href="https://phabricator.kde.org/p/davidedmundson/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> helps me with \
the dbus signals.  I tried to implement them, but the problem was, that the \
processEvents() loop is in a different thread than the Connection instance. Because \
of that the signals weren&#039;t forwarded to D-Bus (hard to see).</p>

<p>He told me that he has an idea how to solve the problem. If this doesn&#039;t work \
though, I would suggest that we ignore the problem of the changing device list on \
plugging events. For my touchpad KCM it&#039;s in some way irrelevant anyway, \
because:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">Most touchpads aren&#039;t removable.</li>
<li class="remarkup-list-item">On the rare occasion of a user plugging in or \
disconnecting a touchpad while being in the touchpad KCM, I would use the signal only \
to show a warning message to the user, that he should restart the KCM (I think \
it&#039;s over-engineered to implement logic to update the device list in real time \
in these very rare cases).</li> </ol></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3479" \
rel="noreferrer">https://phabricator.kde.org/D3479</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>subdiff, KWin, Plasma<br /><strong>Cc: \
</strong>graesslin, davidedmundson, plasma-devel, kwin, KWin, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]