[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D3538: Drop resize animation when adding pages
From:       "mart (Marco Martin)" <noreply () phabricator ! kde ! org>
Date:       2016-11-30 14:12:59
Message-ID: 20161130141259.30944.45861.82DF5648 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> PageRow.qml:429
>                  id: stateTimer
> -                interval: 150
> +                interval: 0
>                  onTriggered: container.state = container.pendingState

if the interval went to 0, then couldn't be possible to remove the timer completely?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D3538

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: jensreuterberg, colomar, plasma-devel, apol

[Attachment #3 (text/html)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3538" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3538#inline-13922" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">PageRow.qml:429</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">       \
<span style="color: #aa4000">id: stateTimer</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #ffd0d0;">                <span style="color: \
#aa4000">interval:</span> <span class="bright"></span><span style="color: \
#601200"><span class="bright">15</span>0</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;">                <span style="color: \
#aa4000">interval:</span> <span style="color: #601200">0</span> </div><div \
style="padding: 0 8px; margin: 0 4px; ">                <span style="color: \
#aa4000">onTriggered:</span> <span style="color: #004012">container</span><span \
class="p">.</span><span style="color: #004012">state</span> <span style="color: \
#aa2211">=</span> <span style="color: #004012">container</span><span \
class="p">.</span><span style="color: #004012">pendingState</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if \
the interval went to 0, then couldn&#039;t be possible to remove the timer \
completely?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3538" \
rel="noreferrer">https://phabricator.kde.org/D3538</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>apol, Kirigami, mart<br /><strong>Cc: \
</strong>jensreuterberg, colomar, plasma-devel, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]