From kde-panel-devel  Wed Nov 30 11:50:14 2016
From: "aacid (Albert Astals Cid)" <noreply () phabricator ! kde ! org>
Date: Wed, 30 Nov 2016 11:50:14 +0000
To: kde-panel-devel
Subject: [Differential] [Commented On] D3530: Import plasma-workspace kioslaves
Message-Id: <20161130115014.31206.50419.287CF6A6 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=148050662717352
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--af9195c6043e45deb983fd6f950f3e71"

--af9195c6043e45deb983fd6f950f3e71
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

aacid added a comment.


  In https://phabricator.kde.org/D3530#66090, @mart wrote:
  
  > In https://phabricator.kde.org/D3530#65734, @aacid wrote:
  >
  > > > Dolphin in other environments currently gives a big error until you install plasma-workspace, which defeats the point of the split.
  > >
  > > Maybe Dolphin needs to be patched not to assume remote:/ will always be available?
  >
  >
  > tough remote is a functionality that makes sense regardless in which desktop you're in
  
  
  Agreed, and we should encourage packagers to provide that dependency, but on the source code level I think it makes sense to gracefully detect that one of your runtime dependencies is missing

REVISION DETAIL
  https://phabricator.kde.org/D3530

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #frameworks, #plasma, dfaure
Cc: mart, aacid, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--af9195c6043e45deb983fd6f950f3e71
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">aacid=20added=20a=20comment.
</td><a=20style=3D"text-decoration:=20none;=20padding:=204px=208px;=20margi=
n:=200=208px=208px;=20float:=20right;=20color:=20#464C5C;=20font-weight:=20=
bold;=20border-radius:=203px;=20background-color:=20#F7F7F9;=20background-i=
mage:=20linear-gradient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-bloc=
k;=20border:=201px=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phabric=
ator.kde.org/D3530"=20rel=3D"noreferrer">View=20Revision</a></tr></table><b=
r=20/><div><div><blockquote=20style=3D"border-left:=203px=20solid=20#8C98B8;
=20=20=20=20=20=20=20=20=20=20color:=20#6B748C;
=20=20=20=20=20=20=20=20=20=20font-style:=20italic;
=20=20=20=20=20=20=20=20=20=20margin:=204px=200=2012px=200;
=20=20=20=20=20=20=20=20=20=20padding:=208px=2012px;
=20=20=20=20=20=20=20=20=20=20background-color:=20#F8F9FC;">
<div=20style=3D"font-style:=20normal;
=20=20=20=20=20=20=20=20=20=20padding-bottom:=204px;">In=20<a=20href=3D"htt=
ps://phabricator.kde.org/D3530#66090"=20style=3D"background-color:=20#e7e7e=
7;
=20=20=20=20=20=20=20=20=20=20border-color:=20#e7e7e7;
=20=20=20=20=20=20=20=20=20=20border-radius:=203px;
=20=20=20=20=20=20=20=20=20=20padding:=200=204px;
=20=20=20=20=20=20=20=20=20=20font-weight:=20bold;
=20=20=20=20=20=20=20=20=20=20color:=20black;text-decoration:=20none;"=20re=
l=3D"noreferrer">D3530#66090</a>,=20<a=20href=3D"https://phabricator.kde.or=
g/p/mart/"=20style=3D"
=20=20=20=20=20=20=20=20=20=20=20=20=20=20border-color:=20#f1f7ff;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20color:=20#19558d;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20background-color:=20#f1f7ff;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20border:=201px=20solid=20tra=
nsparent;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20border-radius:=203px;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20font-weight:=20bold;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20padding:=200=204px;"=20rel=
=3D"noreferrer">@mart</a>=20wrote:</div>
<div=20style=3D"margin:=200;
=20=20=20=20=20=20=20=20=20=20padding:=200;
=20=20=20=20=20=20=20=20=20=20border:=200;
=20=20=20=20=20=20=20=20=20=20color:=20rgb(107,=20116,=20140);"><blockquote=
=20style=3D"border-left:=203px=20solid=20#8C98B8;
=20=20=20=20=20=20=20=20=20=20color:=20#6B748C;
=20=20=20=20=20=20=20=20=20=20font-style:=20italic;
=20=20=20=20=20=20=20=20=20=20margin:=204px=200=2012px=200;
=20=20=20=20=20=20=20=20=20=20padding:=208px=2012px;
=20=20=20=20=20=20=20=20=20=20background-color:=20#F8F9FC;">
<div=20style=3D"font-style:=20normal;
=20=20=20=20=20=20=20=20=20=20padding-bottom:=204px;">In=20<a=20href=3D"htt=
ps://phabricator.kde.org/D3530#65734"=20style=3D"background-color:=20#e7e7e=
7;
=20=20=20=20=20=20=20=20=20=20border-color:=20#e7e7e7;
=20=20=20=20=20=20=20=20=20=20border-radius:=203px;
=20=20=20=20=20=20=20=20=20=20padding:=200=204px;
=20=20=20=20=20=20=20=20=20=20font-weight:=20bold;
=20=20=20=20=20=20=20=20=20=20color:=20black;text-decoration:=20none;"=20re=
l=3D"noreferrer">D3530#65734</a>,=20<a=20href=3D"https://phabricator.kde.or=
g/p/aacid/"=20style=3D"
=20=20=20=20=20=20=20=20=20=20=20=20=20=20border-color:=20#f1f7ff;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20color:=20#19558d;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20background-color:=20#f1f7ff;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20border:=201px=20solid=20tra=
nsparent;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20border-radius:=203px;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20font-weight:=20bold;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20padding:=200=204px;"=20rel=
=3D"noreferrer">@aacid</a>=20wrote:</div>
<div=20style=3D"margin:=200;
=20=20=20=20=20=20=20=20=20=20padding:=200;
=20=20=20=20=20=20=20=20=20=20border:=200;
=20=20=20=20=20=20=20=20=20=20color:=20rgb(107,=20116,=20140);"><blockquote=
=20style=3D"border-left:=203px=20solid=20#a7b5bf;=20color:=20#464c5c;=20fon=
t-style:=20italic;=20margin:=204px=200=2012px=200;=20padding:=204px=2012px;=
=20background-color:=20#f8f9fc;"><p>Dolphin=20in=20other=20environments=20c=
urrently=20gives=20a=20big=20error=20until=20you=20install=20plasma-workspa=
ce,=20which=20defeats=20the=20point=20of=20the=20split.</p></blockquote>

<p>Maybe=20Dolphin=20needs=20to=20be=20patched=20not=20to=20assume=20remote=
:/=20will=20always=20be=20available?</p></div>
</blockquote>

<p>tough=20remote=20is=20a=20functionality=20that=20makes=20sense=20regardl=
ess=20in=20which=20desktop=20you&#039;re=20in</p></div>
</blockquote>

<p>Agreed,=20and=20we=20should=20encourage=20packagers=20to=20provide=20tha=
t=20dependency,=20but=20on=20the=20source=20code=20level=20I=20think=20it=
=20makes=20sense=20to=20gracefully=20detect=20that=20one=20of=20your=20runt=
ime=20dependencies=20is=20missing</p></div></div><br=20/><div><strong>REVIS=
ION=20DETAIL</strong><div><a=20href=3D"https://phabricator.kde.org/D3530"=
=20rel=3D"noreferrer">https://phabricator.kde.org/D3530</a></div></div><br=
=20/><div><strong>EMAIL=20PREFERENCES</strong><div><a=20href=3D"https://pha=
bricator.kde.org/settings/panel/emailpreferences/"=20rel=3D"noreferrer">htt=
ps://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><b=
r=20/><div><strong>To:=20</strong>elvisangelaccio,=20Frameworks,=20Plasma,=
=20dfaure<br=20/><strong>Cc:=20</strong>mart,=20aacid,=20davidedmundson,=20=
plasma-devel,=20lesliezhai,=20ali-mohamed,=20jensreuterberg,=20abetts,=20se=
bas<br=20/></div>
--af9195c6043e45deb983fd6f950f3e71--