[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Updated, 374 lines] D3539: [Notifications] Show interactive thumbnails on notificati
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-11-30 9:36:13
Message-ID: 20161130093613.31653.1205.0D6F77F8 () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik updated this revision to Diff 8625.
broulik added a comment.


  - Reduce preview area in height (now 1/3 of the dialog width instead of 1/2 as \
before – I tried 1/4 but given the aspect ratio it would make the preview hard to \
                see imho)
  - When there is one item but a preview could not be generated show it as regular \
                sized file instead of huge file icon
  - Use PlasmaCore.IconItem for the icon instead of having the Previewer generate a \
pixmap off the theme icon

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3539?vs=8608&id=8625

REVISION DETAIL
  https://phabricator.kde.org/D3539

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/plugin/CMakeLists.txt
  applets/notifications/plugin/notificationshelperplugin.cpp
  applets/notifications/plugin/thumbnailer.cpp
  applets/notifications/plugin/thumbnailer.h
  dataengines/notifications/notificationsengine.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">broulik updated this revision to Diff 8625.<br />broulik \
added a comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 \
8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3539" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><ul class="remarkup-list"> <li \
class="remarkup-list-item">Reduce preview area in height (now 1/3 of the dialog width \
instead of 1/2 as before – I tried 1/4 but given the aspect ratio it would make the \
preview hard to see imho)</li> <li class="remarkup-list-item">When there is one item \
but a preview could not be generated show it as regular sized file instead of huge \
file icon</li> <li class="remarkup-list-item">Use PlasmaCore.IconItem for the icon \
instead of having the Previewer generate a pixmap off the theme icon</li> \
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>CHANGES SINCE LAST \
UPDATE</strong><div><a href="https://phabricator.kde.org/D3539?vs=8608&amp;id=8625" \
rel="noreferrer">https://phabricator.kde.org/D3539?vs=8608&amp;id=8625</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3539" \
rel="noreferrer">https://phabricator.kde.org/D3539</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/notifications/package/contents/ui/NotificationItem.qml<br \
/> applets/notifications/package/contents/ui/NotificationPopup.qml<br />
applets/notifications/plugin/CMakeLists.txt<br />
applets/notifications/plugin/notificationshelperplugin.cpp<br />
applets/notifications/plugin/thumbnailer.cpp<br />
applets/notifications/plugin/thumbnailer.h<br />
dataengines/notifications/notificationsengine.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, Plasma: Design<br /><strong>Cc: \
</strong>colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]