[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Request, 328 lines] D3539: [Notifications] Show interactive thumbnails on notificati
From: "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date: 2016-11-29 16:47:58
Message-ID: differential-rev-PHID-DREV-sdpelrhtwi6fepetyls7-req () phabricator ! kde ! org
[Download RAW message or body]
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When a notification contains URLs, they will be shown as a large preview (in case \
of one thumbnail) or multiple in a strip (similar to what Klipper does).
The previews can be clicked to open the file and can be dragged anywhere (e.g. to a \
webbrowser or chat window).
TEST PLAN
F555195: Screenshot_20161129_173221.png <https://phabricator.kde.org/F555195>
Spectacle can take advantage of this (the cursor actually changes to the open hand \
cursor to indicate it's a draggable surface but this cannot be seen in the \
screenshot) F555196: Screenshot_20161129_173311.png \
<https://phabricator.kde.org/F555196> Regular image passed as argument
F555197: Screenshot_20161129_173410.png <https://phabricator.kde.org/F555197>
Multiple files that fit in the notification
F555198: Screenshot_20161129_173431.png <https://phabricator.kde.org/F555198>
Too many files, overflow
F555199: Screenshot_20161129_173215.png <https://phabricator.kde.org/F555199>
Single file without thumbnail - ideally it would then fall back to the small square \
representation but that is difficult to achieve
Clicking the thumbnails currently doesn't work because the MEL eats the click away. \
Also, right-click does nothing - would be neat to have the regular KIO file context \
menu there. It also doesn't properly work with grouping, ie. when two notifications \
are grouped together, the thumbnail shown is the one from the last notification.
Needs https://git.reviewboard.kde.org/r/129586/
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3539
AFFECTED FILES
applets/notifications/package/contents/ui/NotificationItem.qml
applets/notifications/package/contents/ui/NotificationPopup.qml
applets/notifications/plugin/CMakeLists.txt
applets/notifications/plugin/notificationshelperplugin.cpp
applets/notifications/plugin/thumbnailer.cpp
applets/notifications/plugin/thumbnailer.h
dataengines/notifications/notificationsengine.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, Plasma: Design.<br />broulik set the repository for this revision to R120 \
Plasma Workspace.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3539" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>When a notification contains URLs, they will be shown as a \
large preview (in case of one thumbnail) or multiple in a strip (similar to what \
Klipper does).</p>
<p>The previews can be clicked to open the file and can be dragged anywhere (e.g. to \
a webbrowser or chat window).</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p><a href="https://phabricator.kde.org/F555195" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F555195: \
Screenshot_20161129_173221.png</a><br /> Spectacle can take advantage of this (the \
cursor actually changes to the open hand cursor to indicate it's a draggable \
surface but this cannot be seen in the screenshot)<br /> <a \
href="https://phabricator.kde.org/F555196" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F555196: \
Screenshot_20161129_173311.png</a><br /> Regular image passed as argument<br />
<a href="https://phabricator.kde.org/F555197" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F555197: \
Screenshot_20161129_173410.png</a><br /> Multiple files that fit in the \
notification<br /> <a href="https://phabricator.kde.org/F555198" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F555198: \
Screenshot_20161129_173431.png</a><br /> Too many files, overflow<br />
<a href="https://phabricator.kde.org/F555199" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F555199: \
Screenshot_20161129_173215.png</a><br /> Single file without thumbnail - ideally it \
would then fall back to the small square representation but that is difficult to \
achieve</p>
<p>Clicking the thumbnails currently doesn't work because the MEL eats the click \
away. Also, right-click does nothing - would be neat to have the regular KIO file \
context menu there.<br /> It also doesn't properly work with grouping, ie. when \
two notifications are grouped together, the thumbnail shown is the one from the last \
notification.</p>
<p>Needs <a href="https://git.reviewboard.kde.org/r/129586/" class="remarkup-link" \
target="_blank" rel="noreferrer">https://git.reviewboard.kde.org/r/129586/</a></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3539" \
rel="noreferrer">https://phabricator.kde.org/D3539</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/notifications/package/contents/ui/NotificationItem.qml<br \
/> applets/notifications/package/contents/ui/NotificationPopup.qml<br />
applets/notifications/plugin/CMakeLists.txt<br />
applets/notifications/plugin/notificationshelperplugin.cpp<br />
applets/notifications/plugin/thumbnailer.cpp<br />
applets/notifications/plugin/thumbnailer.h<br />
dataengines/notifications/notificationsengine.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, Plasma: Design<br /><strong>Cc: \
</strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic