[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 25 lines] D3533: Select correct index without timer
From:       "mart (Marco Martin)" <noreply () phabricator ! kde ! org>
Date:       2016-11-28 17:38:10
Message-ID: differential-rev-PHID-DREV-up42ji22ewrrwdxhhhvv-req () phabricator ! kde ! org
[Download RAW message or body]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  remove the timer that selects the index at startup
  that caused flickering and things moving around since
  index 0 got selected, then moved to the correct one only after a while.

TEST PLAN
  correct theme gets highlighed at startup
  probably i'll port l&f kcm currentSelectedIndex property to indexOf
  invokable as well.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/selectindex

REVISION DETAIL
  https://phabricator.kde.org/D3533

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">mart created this revision.<br />mart added a reviewer: \
Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3533" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>remove \
the timer that selects the index at startup<br /> that caused flickering and things \
moving around since<br /> index 0 got selected, then moved to the correct one only \
after a while.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>correct \
theme gets highlighed at startup<br /> probably i&#039;ll port l&amp;f kcm \
currentSelectedIndex property to indexOf<br /> invokable as well.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>phab/selectindex</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3533" \
rel="noreferrer">https://phabricator.kde.org/D3533</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kcms/desktoptheme/kcm.cpp<br /> \
kcms/desktoptheme/kcm.h<br /> \
kcms/desktoptheme/package/contents/ui/main.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>plasma-devel, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]