[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 129 lines] D3532: Select correct index without timer
From:       "mart (Marco Martin)" <noreply () phabricator ! kde ! org>
Date:       2016-11-28 17:09:58
Message-ID: differential-rev-PHID-DREV-pe4bn42l5cui2bvc6s4t-req () phabricator ! kde ! org
[Download RAW message or body]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  select the correct index upon loading when the count changes.
  this removes the flicker at startup and the view is at the correct
  wallpaper since the first frame. Also, now when a wallpaper is
  downloaded with knewstuff, the old wallpaper stays selected,
  it doesn't get resetted to the first wallpaper anymore

TEST PLAN
  open wallpaer dialog, no more flicker
  install a new wallpaper, the currently selected one stays selected

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/wallpselectedindex

REVISION DETAIL
  https://phabricator.kde.org/D3532

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml
  wallpapers/image/imagepackage/platformcontents/touch/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/platformcontents/touch/ui/config.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">mart created this revision.<br />Restricted Application added \
a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3532" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>select \
the correct index upon loading when the count changes.<br /> this removes the flicker \
at startup and the view is at the correct<br /> wallpaper since the first frame. \
Also, now when a wallpaper is<br /> downloaded with knewstuff, the old wallpaper \
stays selected,<br /> it doesn&#039;t get resetted to the first wallpaper \
anymore</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>open wallpaer \
dialog, no more flicker<br /> install a new wallpaper, the currently selected one \
stays selected</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 \
Plasma Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>phab/wallpselectedindex</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3532" \
rel="noreferrer">https://phabricator.kde.org/D3532</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>wallpapers/image/backgroundlistmodel.cpp<br /> \
wallpapers/image/backgroundlistmodel.h<br /> \
wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml<br /> \
wallpapers/image/imagepackage/contents/ui/config.qml<br /> \
wallpapers/image/imagepackage/platformcontents/phone/ui/WallpaperDelegate.qml<br /> \
wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml<br /> \
wallpapers/image/imagepackage/platformcontents/touch/ui/WallpaperDelegate.qml<br /> \
wallpapers/image/imagepackage/platformcontents/touch/ui/config.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart<br /><strong>Cc: </strong>plasma-devel, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]