[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D3530: Import plasma-workspace kioslaves
From:       "elvisangelaccio (Elvis Angelaccio)" <noreply () phabricator ! kde ! org>
Date:       2016-11-28 16:42:56
Message-ID: 20161128164256.13591.28035.7F72E700 () phabricator ! kde ! org
[Download RAW message or body]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D3530#65685, @davidedmundson wrote:
  
  > Would it be possible to make the version in frameworks co-installable with \
plasma?  >
  > As long as the .protocol file still says protocol=desktop, dolphin and Plasma \
won't care what the .protocol filename is; the protocol file says which library to \
load, and KIO will just pick the first one that matches. At which point we can rename \
the .protocol and .so file to desktop5/remote5, without any issue.  >
  > People without Plasma load the version from frameworks, people with Plasma use \
the Plasma one until 5.9, when we just stop installing ours having already raised the \
frameworks dependency. It works in theory..  >
  > The only thing I'm not sure of is the kded modules and the other sort of \
unrelated .desktop files installed by the desktop kioslave.  
  
  Probably also the kde modules need renaming? Both p-w and kio installs them in  \
`<prefix>/qt/plugins/kf5/kded/`

REVISION DETAIL
  https://phabricator.kde.org/D3530

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, dfaure, #frameworks, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas


[Attachment #3 (text/html)]

<table><tr><td style="">elvisangelaccio added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3530" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3530#65685" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D3530#65685</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Would it be possible to make the version in \
frameworks co-installable with plasma?</p>

<p>As long as the .protocol file still says protocol=desktop, dolphin and Plasma \
won&#039;t care what the .protocol filename is; the protocol file says which library \
to load, and KIO will just pick the first one that matches. At which point we can \
rename the .protocol and .so file to desktop5/remote5, without any issue.</p>

<p>People without Plasma load the version from frameworks, people with Plasma use the \
Plasma one until 5.9, when we just stop installing ours having already raised the \
frameworks dependency. It works in theory..</p>

<p>The only thing I&#039;m not sure of is the kded modules and the other sort of \
unrelated .desktop files installed by the desktop kioslave.</p></div> </blockquote>

<p>Probably also the kde modules need renaming? Both p-w and kio installs them in  \
<tt style="background: #ebebeb; font-size: \
13px;">&lt;prefix&gt;/qt/plugins/kf5/kded/</tt></p></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3530" \
rel="noreferrer">https://phabricator.kde.org/D3530</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>elvisangelaccio, dfaure, Frameworks, Plasma<br \
/><strong>Cc: </strong>davidedmundson, plasma-devel, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]