[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Request, 37 lines] D3528: Select correct index without timer
From: "mart (Marco Martin)" <noreply () phabricator ! kde ! org>
Date: 2016-11-28 12:03:21
Message-ID: differential-rev-PHID-DREV-albxh4svkfnarz2dsn4n-req () phabricator ! kde ! org
[Download RAW message or body]
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
remove the timer that selects the index at startup
that caused flickering and things moving around since
index 0 got selected, then moved to the correct one only after a while.
unfortunately there is not a place (a signal) that says
"the view has been correctly instanced from the model" that
would be where selecting the current index at startup would be the safest.
a place that seems working correctly is on listview onCountChanged
this has to introduce KCMLookandFeel::selectedPluginIndex
that isn't very pretty, but the flickering seems to be gone and
the kcm loads from the correct place of the view from the first
frame is displayed
TEST PLAN
he flickering seems to be gone and the kcm loads from the correct place of the view \
from the first frame is displayed. Once this is in the final form, some other config \
dialogs need the same treatment: plasma theme and wallpapers
REPOSITORY
R119 Plasma Desktop
BRANCH
phab/selectindex
REVISION DETAIL
https://phabricator.kde.org/D3528
AFFECTED FILES
kcms/lookandfeel/kcm.cpp
kcms/lookandfeel/kcm.h
kcms/lookandfeel/package/contents/ui/main.qml
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">mart created this revision.<br />mart added a reviewer: \
Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3528" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><div \
class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">remove the timer that selects \
the index at startup that caused flickering and things moving around since
index 0 got selected, then moved to the correct one only after a while.
unfortunately there is not a place (a signal) that says
"the view has been correctly instanced from the model" that
would be where selecting the current index at startup would be the safest.
a place that seems working correctly is on listview onCountChanged
this has to introduce KCMLookandFeel::selectedPluginIndex
that isn't very pretty, but the flickering seems to be gone and
the kcm loads from the correct place of the view from the first
frame is displayed</pre></div></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>he flickering seems to be gone and the kcm loads from the \
correct place of the view from the first frame is displayed. Once this is in the \
final form, some other config dialogs need the same treatment: plasma theme and \
wallpapers</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>phab/selectindex</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3528" \
rel="noreferrer">https://phabricator.kde.org/D3528</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kcms/lookandfeel/kcm.cpp<br /> \
kcms/lookandfeel/kcm.h<br /> \
kcms/lookandfeel/package/contents/ui/main.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>plasma-devel, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic