[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129309: Fix broken systemloadviewer tooltip
From: Miklós Máté <mtmkls () gmail ! com>
Date: 2016-11-02 10:20:29
Message-ID: 20161102102029.15979.67444 () mimi ! kde ! org
[Download RAW message or body]
--===============8384561677621037292==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129309/#review100492
-----------------------------------------------------------
Ship it!
Oh, you're right. I forgot to add this to my commit. Thanks for fixing it.
- Miklós Máté
On Nov. 2, 2016, 7:15 a.m., Antonio Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129309/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2016, 7:15 a.m.)
>
>
> Review request for Plasma, David Edmundson and Miklós Máté.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> Commit 346b492 broke the systemloadviewer tooltip, it's trying to use a variable \
> that is not defined.
>
> Diffs
> -----
>
> applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml bf299b7
>
> Diff: https://git.reviewboard.kde.org/r/129309/diff/
>
>
> Testing
> -------
>
> Tooltip works again
>
>
> Thanks,
>
> Antonio Rojas
>
>
--===============8384561677621037292==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129309/">https://git.reviewboard.kde.org/r/129309/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh, \
you're right. I forgot to add this to my commit. Thanks for fixing it.</p></pre> <br \
/>
<p>- Miklós Máté</p>
<br />
<p>On November 2nd, 2016, 7:15 a.m. UTC, Antonio Rojas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, David Edmundson and Miklós Máté.</div>
<div>By Antonio Rojas.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2016, 7:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Commit 346b492 broke the systemloadviewer tooltip, \
it's trying to use a variable that is not defined.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tooltip works again</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span \
style="color: grey">(bf299b7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129309/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8384561677621037292==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic