[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D3200: Add a widget gallery page to the Dashboard.
From: "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date: 2016-11-01 14:18:56
Message-ID: 20161101141855.45394.83009.3159EA56 () phabricator ! kde ! org
[Download RAW message or body]
broulik added a comment.
Sorry for being late to the party
INLINE COMMENTS
> DashboardRepresentation.qml:102
> + if (tabBar.activeTab == 1 /* Widgets */ || tabBar.hoveredTab == 1) {
> + root.widgetExplorer = widgetExplorerComponent.createObject(root);
> + root.widgetExplorer.containment = \
> containmentInterface.screenContainment(plasmoid);
Would it help if you pass the containment to the createObject call to avoid some \
re-evaluation?
root.widgetExplorer = widgetExplorerComponent.createObject(root, {
containment: containmentInterface.screenContainment(plasmoid)
})
> containmentinterface.h:53
> + static Q_INVOKABLE bool screenContainmentMutable(QObject \
> *appletInterface); + static Q_INVOKABLE void \
> ensureMutable(Plasma::Containment *containment);
Note that you cannot unlock widgets if kiosk restrictions (SystemImmutable) apply in \
which case this entire feature should be disabled or else you open a neat way for \
users to screw with a locked-down desktop.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3200
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, mart
Cc: broulik, davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3200" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Sorry for being late to the \
party</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3200#inline-12524" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">DashboardRepresentation.qml:102</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">if</span> \
<span class="p">(</span><span style="color: #004012">tabBar</span><span \
class="p">.</span><span style="color: #004012">activeTab</span> <span style="color: \
#aa2211">==</span> <span style="color: #601200">1</span> <span style="color: \
#74777d">/* Widgets */</span> <span style="color: #aa2211">||</span> <span \
style="color: #004012">tabBar</span><span class="p">.</span><span style="color: \
#004012">hoveredTab</span> <span style="color: #aa2211">==</span> <span style="color: \
#601200">1</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
style="color: #004012">root</span><span class="p">.</span><span style="color: \
#004012">widgetExplorer</span> <span style="color: #aa2211">=</span> <span \
style="color: #004012">widgetExplorerComponent</span><span class="p">.</span><span \
style="color: #004012">createObject</span><span class="p">(</span><span style="color: \
#004012">root</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span style="color: \
#004012">root</span><span class="p">.</span><span style="color: \
#004012">widgetExplorer</span><span class="p">.</span><span style="color: \
#004012">containment</span> <span style="color: #aa2211">=</span> <span style="color: \
#004012">containmentInterface</span><span class="p">.</span><span style="color: \
#004012">screenContainment</span><span class="p">(</span><span style="color: \
#004012">plasmoid</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Would it help if you pass the containment to the createObject call to avoid \
some re-evaluation?</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">root.widgetExplorer = \
widgetExplorerComponent.createObject(root, { containment: \
containmentInterface.screenContainment(plasmoid) })</pre></div></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D3200#inline-12525" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">containmentinterface.h:53</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span style="color: \
#aa4000">static</span> <span class="n">Q_INVOKABLE</span> <span style="color: \
#aa4000">bool</span> <span style="color: \
#004012">screenContainmentMutable</span><span class="p">(</span><span \
class="n">QObject</span> <span style="color: #aa2211">*</span><span \
class="n">appletInterface</span><span class="p">);</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: \
#aa4000">static</span> <span class="n">Q_INVOKABLE</span> <span style="color: \
#aa4000">void</span> <span style="color: #004012">ensureMutable</span><span \
class="p">(</span><span class="n">Plasma</span><span style="color: \
#aa2211">::</span><span class="n">Containment</span> <span style="color: \
#aa2211">*</span><span class="n">containment</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Note that you cannot unlock widgets if kiosk restrictions \
(SystemImmutable) apply in which case this entire feature should be disabled or else \
you open a neat way for users to screw with a locked-down \
desktop.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3200" \
rel="noreferrer">https://phabricator.kde.org/D3200</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>hein, Plasma, mart<br /><strong>Cc: </strong>broulik, \
davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic