[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Accepted] D3200: Add a widget gallery page to the Dashboard.
From:       "mart (Marco Martin)" <noreply () phabricator ! kde ! org>
Date:       2016-11-01 12:04:24
Message-ID: 20161101120423.30792.18483.3A863ED0 () phabricator ! kde ! org
[Download RAW message or body]

mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> hein wrote in DashboardRepresentation.qml:527
> Good point, what style do you suggest?

to be done in a separate commit, but to me it suggests a state machine should be \
used. even with just two states, but opacity, z and enabled would be PropertyChanges \
and opacity would have a transition set on it

> hein wrote in containmentinterface.h:52
> Mostly because the Widget Explorer model takes a containment assignment to work, \
> and I don't know what that code does (or will do in the future) if passed an \
> immutable containment, so it seemed safer.

ok

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3200

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">mart accepted this revision.<br />mart added a reviewer: \
mart.<br />mart added inline comments.<br />This revision is now accepted and ready \
to land. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3200" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3200#inline-12507" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">hein</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">DashboardRepresentation.qml:527</span></div> <div style="margin: 8px 0; \
padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Good point, \
what style do you suggest?</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">to be done in a separate commit, but to me \
it suggests a state machine should be used.<br /> even with just two states, but \
opacity, z and enabled would be PropertyChanges and opacity would have a transition \
set on it</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3200#inline-12508" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">hein</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">containmentinterface.h:52</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Mostly because the Widget \
Explorer model takes a containment assignment to work, and I don&#039;t know what \
that code does (or will do in the future) if passed an immutable containment, so it \
seemed safer.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">ok</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3200" \
rel="noreferrer">https://phabricator.kde.org/D3200</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>hein, Plasma, mart<br /><strong>Cc: </strong>mart, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic