[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 26 lines] D3220: Introduce new pre-layout script hook
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-11-01 11:16:24
Message-ID: differential-rev-PHID-DREV-53ggd6i5ka4yxpg2oj6k-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  layout.js used to be run before any containments were added. This was
  broken in https://phabricator.kde.org/rPLASMAWORKSPACEa697d291f98e923ef0c5d2221bf04187600d4ea8 \
which creates desktop containments for that activity  first.
  
  However, some scripts rely on being able to alter global configuration
  before any containments are loaded.
  
  In order to allow the same functionality we need to provide a new hook
  for whatever these scripts may need to do.
  
  BUG: 371704

TEST PLAN
  Not done yet.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3220

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3220" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>layout.js used to be run before any containments were added. \
This was<br /> broken in <a \
href="https://phabricator.kde.org/rPLASMAWORKSPACEa697d291f98e923ef0c5d2221bf04187600d4ea8" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">a697d291</a> which \
creates desktop containments for that activity<br /> first.</p>

<p>However, some scripts rely on being able to alter global configuration<br />
before any containments are loaded.</p>

<p>In order to allow the same functionality we need to provide a new hook<br />
for whatever these scripts may need to do.</p>

<p>BUG: 371704</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Not done \
yet.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE \
Plasma Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3220" \
rel="noreferrer">https://phabricator.kde.org/D3220</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>shell/shellcorona.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]