--===============7878404298877012023== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 31, 2016, 1:36 p.m., Marco Martin wrote: > > src/widgets/kurlrequesterdialog.cpp, line 51 > > > > > > remove whitespace > > Aniketh Girish wrote: > Hope the error was solved. I request someone to push the changes on my behalf. Done, thanks Aniketh. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129294/#review100433 ----------------------------------------------------------- On Oct. 31, 2016, 9:57 p.m., Aniketh Girish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129294/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 9:57 p.m.) > > > Review request for Plasma, David Faure and Eike Hein. > > > Bugs: 369377 > https://bugs.kde.org/show_bug.cgi?id=369377 > > > Repository: kio > > > Description > ------- > > There was a unwanted clear button as well as a inline clear. The clear button was old enough, so removed that button and the inline clear does the work. > > > Diffs > ----- > > src/widgets/kurlrequesterdialog.h ea2533310fdb69bf8f4ac6bae826ea45439fdeb6 > src/widgets/kurlrequesterdialog.cpp 4c2f526fe9bbb6fbec8b94044bea8e37aa4b5204 > > Diff: https://git.reviewboard.kde.org/r/129294/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Before removing the clear button. > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/31/b28e7448-0b6a-4a5b-a410-ff8523596784__Before_Changes.png > After changing the code for clear button. > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/31/b45f8107-5c4f-4697-b1ae-7c0431259fcb__After_Changes.png > > > Thanks, > > Aniketh Girish > > --===============7878404298877012023== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129294/

On October 31st, 2016, 1:36 p.m. CET, Marco Martin wrote:

src/widgets/kurlrequesterdialog.cpp (Diff revision 1)
51 
    QPushButton *clearButton;
 50 
    
remove whitespace

On October 31st, 2016, 2:34 p.m. CET, Aniketh Girish wrote:

Hope the error was solved. I request someone to push the changes on my behalf.
Done, thanks Aniketh.

- Christoph


On October 31st, 2016, 9:57 p.m. CET, Aniketh Girish wrote:

Review request for Plasma, David Faure and Eike Hein.
By Aniketh Girish.

Updated Oct. 31, 2016, 9:57 p.m.

Bugs: 369377
Repository: kio

Description 

There was a unwanted clear button as well as a inline clear. The clear button was old enough, so removed that button and the inline clear does the work.

Diffs

  • src/widgets/kurlrequesterdialog.h (ea2533310fdb69bf8f4ac6bae826ea45439fdeb6)
  • src/widgets/kurlrequesterdialog.cpp (4c2f526fe9bbb6fbec8b94044bea8e37aa4b5204)

View Diff

File Attachments

  • Before removing the clear button.
  • After changing the code for clear button.
    		•
    --===============7878404298877012023==--