'Review Request 129298: RFC: supporting dependencies on KPackage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 129298: RFC: supporting dependencies on KPackage
From:       Aleix Pol Gonzalez <aleixpol () kde ! org>
Date:       2016-10-31 17:08:45
Message-ID: 20161031170845.5235.21057 () mimi ! kde ! org
[Download RAW message or body]

--===============4741656071328419464==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129298/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.


Repository: kpackage


Description
-------

Makes it possible to specify components to be installed together with a KPackage. \
They will be specified by a url, we'll have handlers for any kind, making reasonably \
extensible and doesn't tie us to a technology.

In this repository I created two Proof of Concept of such handlers, one for the \
appstream urls and one for KNS: kde:scratch/apol/kpackage-install-helpers


Diffs
-----

  autotests/CMakeLists.txt 395b16e 
  autotests/data/testpackagesdep/contents/ui/main.qml PRE-CREATION 
  autotests/data/testpackagesdep/metadata.json PRE-CREATION 
  autotests/data/testpackagesdep/testpackagesdep.testappdataxml PRE-CREATION 
  src/kpackage/config-package.h.cmake 61f2f0c 
  src/kpackage/private/packagejobthread.cpp 0a0cc01 
  src/kpackage/private/packagejobthread_p.h 1babf0b 

Diff: https://git.reviewboard.kde.org/r/129298/diff/


Testing
-------

None. just builds. It's a proof of concept, not even the test I added was tested, it \
was just to display what it could look like.


Thanks,

Aleix Pol Gonzalez


--===============4741656071328419464==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129298/">https://git.reviewboard.kde.org/r/129298/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kpackage
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Makes it possible to specify components to be \
installed together with a KPackage. They will be specified by a url, we'll have \
handlers for any kind, making reasonably extensible and doesn't tie us to a \
technology.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In this repository I created two Proof of Concept of \
such handlers, one for the appstream urls and one for KNS: \
kde:scratch/apol/kpackage-install-helpers</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">None. just builds. It's a proof of concept, not even \
the test I added was tested, it was just to display what it could look \
like.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/CMakeLists.txt <span style="color: grey">(395b16e)</span></li>

 <li>autotests/data/testpackagesdep/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/data/testpackagesdep/metadata.json <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/data/testpackagesdep/testpackagesdep.testappdataxml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>src/kpackage/config-package.h.cmake <span style="color: \
grey">(61f2f0c)</span></li>

 <li>src/kpackage/private/packagejobthread.cpp <span style="color: \
grey">(0a0cc01)</span></li>

 <li>src/kpackage/private/packagejobthread_p.h <span style="color: \
grey">(1babf0b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129298/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============4741656071328419464==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic