[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Request, 339 lines] D3216: WIP: Restore Menubar style config in application style
From: "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date: 2016-10-31 16:05:16
Message-ID: differential-rev-PHID-DREV-d23ujccxyca6zcdks74o-req () phabricator ! kde ! org
[Download RAW message or body]
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This restores the configuration for whether menus should be shown in the \
application (no global menu), as title bar button, or as "widget".
The notification popup is removed and replaced by a simple KMessageWidget. The \
option "Application Menu widget" doesn't actually do anything, it just enables global \
menu but not visible to the user. Perhaps it should show a hint, like "Place the \
Application Menu widget in a panel" or something like that.
TEST PLAN
Placement for the message widget needs fixing.
When I change the style from inapp to something else it shows that this setting \
will only work after restarting the respective app. The title bar button in KWin \
comes and goes as I change it to "title bar button" or something else.
Technically, you could use window decoration button and the appmenu applet \
simultaneously (nothing keeps you from placing a appmenu widget even while it's set \
to title bar button) but that will cause interaction problems, eg. who's turn is it \
if I press Alt? The plasma applet could even say "application menu applet is \
currently not enabled [enable]" so we really allow only one of the two (we need \
something like this anyway when you disable appmenu and you have the applet) \
F394768: Screenshot_20161031_164535.png <https://phabricator.kde.org/F394768>
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3216
AFFECTED FILES
kcms/style/CMakeLists.txt
kcms/style/finetuning.ui
kcms/style/kcmstyle.cpp
kcms/style/kcmstyle.notifyrc
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, Plasma: Design.<br />broulik set the repository for this revision to \
rPLASMADESKTOP Plasma Desktop.<br />Restricted Application added a project: \
Plasma.<br />Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3216" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>This restores the configuration for whether menus should be \
shown in the application (no global menu), as title bar button, or as \
"widget".</p>
<p>The notification popup is removed and replaced by a simple KMessageWidget. The \
option "Application Menu widget" doesn't actually do anything, it just \
enables global menu but not visible to the user. Perhaps it should show a hint, like \
"Place the Application Menu widget in a panel" or something like \
that.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Placement for the \
message widget needs fixing.</p>
<p>When I change the style from inapp to something else it shows that this setting \
will only work after restarting the respective app. The title bar button in KWin \
comes and goes as I change it to "title bar button" or something else.</p>
<p>Technically, you could use window decoration button and the appmenu applet \
simultaneously (nothing keeps you from placing a appmenu widget even while it's \
set to title bar button) but that will cause interaction problems, eg. who's \
turn is it if I press Alt?<br /> The plasma applet could even say "application \
menu applet is currently not enabled [enable]" so we really allow only one of \
the two (we need something like this anyway when you disable appmenu and you have the \
applet)<br /> <a href="https://phabricator.kde.org/F394768" style="background-color: \
#e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F394768: \
Screenshot_20161031_164535.png</a></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3216" \
rel="noreferrer">https://phabricator.kde.org/D3216</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kcms/style/CMakeLists.txt<br /> \
kcms/style/finetuning.ui<br /> kcms/style/kcmstyle.cpp<br />
kcms/style/kcmstyle.notifyrc</div></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, Plasma: Design<br /><strong>Cc: \
</strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic