[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 12 lines] D3215: Simplify the window title passed in from the window system
From:       graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date:       2016-10-31 15:12:34
Message-ID: differential-rev-PHID-DREV-voprw6f7ezn4jpxgtfuc-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  So far KWin used the window title provided from the window directly
  without any sanitizing. This could result in broken window decorations
  if the title included line breaks. Those were passed to the decoration
  and depending on the way how the decoration renders the title, it could
  result in visual breakage.
  
  Having line breaks in a window title doesn't make sense. Given that KWin
  now simplifies the title when copying it to it's own structure. This
  also ensures that the title passed to e.g. task manager does not have
  any line breaks on Wayland.
  
  BUG: 323798
  FIXED-IN: 5.8.3

TEST PLAN
  Opened the web page in a nested KWin, properly rendered now.

REPOSITORY
  rKWIN KWin

BRANCH
  simplified-title-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3215

AFFECTED FILES
  autotests/integration/shell_client_test.cpp
  autotests/integration/x11_client_test.cpp
  client.cpp
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">graesslin created this revision.<br />graesslin added \
reviewers: KWin, Plasma.<br />Restricted Application added a project: KWin.<br \
/>Restricted Application added subscribers: kwin, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3215" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>So far KWin used the window title provided from the window \
directly<br /> without any sanitizing. This could result in broken window \
decorations<br /> if the title included line breaks. Those were passed to the \
decoration<br /> and depending on the way how the decoration renders the title, it \
could<br /> result in visual breakage.</p>

<p>Having line breaks in a window title doesn&#039;t make sense. Given that KWin<br \
/> now simplifies the title when copying it to it&#039;s own structure. This<br />
also ensures that the title passed to e.g. task manager does not have<br />
any line breaks on Wayland.</p>

<p>BUG: 323798<br />
FIXED-IN: 5.8.3</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Opened \
the web page in a nested KWin, properly rendered now.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>simplified-title-5.8</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3215" \
rel="noreferrer">https://phabricator.kde.org/D3215</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>autotests/integration/shell_client_test.cpp<br /> \
autotests/integration/x11_client_test.cpp<br /> client.cpp<br />
shell_client.cpp</div></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: \
</strong>plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, \
abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]